Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] use flag '--allow-releaseinfo-change' in some 'apt-get update' calls #4524

Merged
merged 2 commits into from
Aug 17, 2021

Conversation

jameslamb
Copy link
Collaborator

On PRs I opened within the last hour (#4522, #4523), the r-package (ubuntu-latest, R-devel, GCC ASAN/UBSAN) (pull_request) job is failing.

E: Repository 'http://deb.debian.org/debian testing InRelease' changed its 'Codename' value from 'bullseye' to 'bookworm'
Error: Process completed with exit code 100.

https://github.com/microsoft/LightGBM/pull/4523/checks?check_run_id=3332073359

After some research, I think this could be fixed by preferring apt update to apt-get update. A similar error was reported a few hours ago in https://www.mail-archive.com/debian-user@lists.debian.org/msg772749.html, and responses in that thread suggest that running apt update in place of apt-get update can fix it (e.g. https://www.mail-archive.com/debian-user@lists.debian.org/msg772763.html).

As far as I can tell from that thread, this is happening because of this combination of factors:

  1. there was a new Debian release today: https://wiki.debian.org/DebianReleases#Production_Releases
  2. some package(s) shipped in that release with bad metadata related to that new release
  3. apt-get update does not install new dependencies of upgradeable software (https://linuxhint.com/diff_apt_vs_aptget/)

Opening this PR to replace calls to apt-get update with apt update in R jobs using rhub/ container images.

Notes for Reviewers

It's possible similar changes will need to be made for other jobs in the future, and maybe even that we should completely prefer apt to apt-get, but that requires more research and I think it's outside of the scope of this PR.

@jameslamb
Copy link
Collaborator Author

Doesn't seem like this worked 😬

I'm going to try just rebuilding #4522, maybe it was fixed upstrean.

@jameslamb
Copy link
Collaborator Author

I'm going to try just rebuilding #4522, maybe it was fixed upstrean.

That did not work, sadly. https://github.com/microsoft/LightGBM/pull/4522/checks?check_run_id=3334336822

Investigating some other options locally right now.

@jameslamb
Copy link
Collaborator Author

Following another suggestion from https://www.mail-archive.com/debian-user@lists.debian.org/msg772749.html worked for me locally (in a container using the rhub/rocker-gcc-san:latest image).

For the 'apt-get' front-end, the necessary solution is to run the
command 'apt-get update --allow-releaseinfo-change'.

Just pushed 890feea, which I hope will resolve this issue.

@jameslamb jameslamb changed the title [ci] prefer 'apt update' to 'apt-get update' in some R builds [ci] use flag '--allow-releaseinfo-change' in some 'apt-get update' calls Aug 15, 2021
@jameslamb jameslamb marked this pull request as ready for review August 15, 2021 18:45
Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fast fix!

I think we can add this flag to other apt-get update calls.

@StrikerRUS StrikerRUS merged commit fbbe3cc into master Aug 17, 2021
@StrikerRUS StrikerRUS deleted the ci/apt-update branch August 17, 2021 18:13
@jameslamb
Copy link
Collaborator Author

I think we can add this flag to other apt-get update calls.

Sure! I didn't do that here because I think it needs a bit of investigation. I'm not sure what version of apt-get that flag was added in and this project's CI jobs cover a wide range of Ubuntu versions.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants