[python] add type hints to logging functions in basic.py #4527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
requested review from
chivee,
henry0312,
shiyu1994 and
StrikerRUS
as code owners
StrikerRUS
reviewed
Aug 17, 2021
python-package/lightgbm/basic.py
Outdated
| """Join log messages from native library which come by chunks.""" | ||
| msg_normalized = [] | ||
| msg_normalized: List[str] = [] | ||
|
|
||
| @wraps(func) | ||
| def wrapper(msg): |
There was a problem hiding this comment.
Was wrapper() simply missed or you haven't annotated it due to problems with Union in return type?
python/mypy#1693
There was a problem hiding this comment.
oh just missed it
There was a problem hiding this comment.
updated in a1bec4e, mypy didn't have any complaints so I think it's ok
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds type hints to logging code in
python-package/lightgbm/basic.py, as part of #3756.Notes for Reviewers
See #3756 (comment).
I ran
mypy --ignore-missing-imports python-package/lightgbmand don't see any new warnings aboutbasic.pyor code imported from there