[python] Improve error message for plot_metric with Booster #4709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
js850
requested review from
chivee,
henry0312,
jameslamb,
shiyu1994 and
StrikerRUS
as code owners
js850
commented
Oct 23, 2021
StrikerRUS
changed the title
StrikerRUS
requested changes
Oct 23, 2021
There was a problem hiding this comment.
@js850 Thanks a lot for raising the issue about ambiguity in the docs you've noticed and for fixing it! However, I've suggested two small improvements below to the current wording.
StrikerRUS
approved these changes
Oct 26, 2021
|
Won't merge before @shiyu1994's review (#4709 (comment)). |
shiyu1994
approved these changes
Oct 26, 2021
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If plot_metric is used with the Booster type, throw an error explaining how to correctly plot metrics using Booster.
This addresses issue #4702 .