Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some warnings when loading dataset from binary file #4724

Merged
merged 1 commit into from Oct 27, 2021

Conversation

StrikerRUS
Copy link
Collaborator

Refer to #4701 (comment).

Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with this, but in another PR I think it would be useful to change all warnings in this file to use the language "Parameter 'some_param'..." instead of "Config 'some_param'...".

The word "config" refers to how configuration is passed around internally in LightGBM's C++ code, but in documentation (https://lightgbm.readthedocs.io/en/latest/Parameters.html) and in the R and Python APIs, this is referred to as "parameters" or "params". If I wasn't familiar with LightGBM's internals and was just a user of the Python package, for example, I would be confused by what "Config header" means. I would think "what config? and what is in its header?".

@hzy46
Copy link
Contributor

hzy46 commented Oct 27, 2021

I agree with @jameslamb 's opinion about the wording. Parameter sounds better than Config.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants