Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Make dummy classes constructible with any arguments #4749

Merged
merged 2 commits into from Oct 30, 2021

Conversation

StrikerRUS
Copy link
Collaborator

@StrikerRUS StrikerRUS commented Oct 29, 2021

Refer to the following thread #4639 (comment). Making dummy classes constructible with any arguments may help to write tests.

I'm not overriding default __init__() method for three internal classes (prefixed with _) because doing that for two of them (_LGBMRegressorBase and _LGBMClassifierBase) makes autosummary Sphinx extension to fail because of inheritance issues.

@StrikerRUS StrikerRUS marked this pull request as ready for review October 29, 2021 22:19
Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice!

@jameslamb jameslamb merged commit 9a7562d into master Oct 30, 2021
@jameslamb jameslamb deleted the compat_dummy_classes branch October 30, 2021 04:45
@StrikerRUS StrikerRUS mentioned this pull request Jan 6, 2022
13 tasks
@jameslamb jameslamb mentioned this pull request Oct 7, 2022
40 tasks
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants