Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R-package] allow use of categorical_features in Dataset when raw data does not have column names (fixes #4374) #5184

Merged
merged 5 commits into from
Apr 30, 2022
Merged

[R-package] allow use of categorical_features in Dataset when raw data does not have column names (fixes #4374) #5184

merged 5 commits into from
Apr 30, 2022

Conversation

jmoralez
Copy link
Collaborator

Closes #4374.

@jmoralez jmoralez added the fix label Apr 27, 2022
jameslamb
jameslamb requested changes Apr 28, 2022
View reviewed changes
Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Please see my first round of suggestions.

R-package/R/lgb.Dataset.R Outdated Show resolved Hide resolved
R-package/R/lgb.Dataset.R Outdated Show resolved Hide resolved
R-package/tests/testthat/test_dataset.R Outdated Show resolved Hide resolved
R-package/tests/testthat/test_dataset.R Outdated Show resolved Hide resolved
@jmoralez jmoralez changed the title [R-package] check for number of columns if data is matrix for maximum categorical index [R-package] check for number of columns if data is not file for maximum categorical index (fixes #4374) Apr 28, 2022
@jameslamb jameslamb self-requested a review April 28, 2022 15:29
@jameslamb jameslamb changed the title [R-package] check for number of columns if data is not file for maximum categorical index (fixes #4374) [R-package] allow use of categorical_features in Dataset when raw data does not have column names (fixes #4374) Apr 28, 2022
jameslamb
jameslamb approved these changes Apr 28, 2022
View reviewed changes
Copy link
Collaborator

@jameslamb jameslamb left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look great, thank you so much for fixing this!

I just proposed a change to the PR title as well, to make it a bit clearer in the release notes what the benefit of this change is. Feel free to change it back if you disagree.

@StrikerRUS StrikerRUS merged commit 8359da6 into microsoft:master Apr 30, 2022
@jmoralez jmoralez deleted the ds-categ-nonames branch April 30, 2022 19:01
@jameslamb jameslamb mentioned this pull request Oct 7, 2022
Closed
40 tasks
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jameslamb jameslamb jameslamb approved these changes

@Laurae2 Laurae2 Awaiting requested review from Laurae2

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
3 participants
@jmoralez @jameslamb @StrikerRUS