Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default definition for GetColWiseData and GetColWiseData #5413

Merged
merged 3 commits into from Aug 16, 2022
Merged

Add default definition for GetColWiseData and GetColWiseData #5413

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3fee4c8
add default definition for GetColWiseData and GetColWiseData
shiyu1994 Aug 10, 2022
7657f82
fix warnings of template instantiation
shiyu1994 Aug 16, 2022
ea264f6
remove files in Makevars and LightGBM.vcxproj
shiyu1994 Aug 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/io/dense_bin.hpp
View file
Open in desktop
Expand Up @@ -461,9 +461,13 @@ class DenseBin : public Bin {

DenseBin<VAL_T, IS_4BIT>* Clone() override;

const void* GetColWiseData(uint8_t* bit_type, bool* is_sparse, std::vector<BinIterator*>* bin_iterator, const int num_threads) const override;
const void* GetColWiseData(uint8_t* /*bit_type*/, bool* /*is_sparse*/, std::vector<BinIterator*>* /*bin_iterator*/, const int /*num_threads*/) const override {
return nullptr;
}

const void* GetColWiseData(uint8_t* bit_type, bool* is_sparse, BinIterator** bin_iterator) const override;
const void* GetColWiseData(uint8_t* /*bit_type*/, bool* /*is_sparse*/, BinIterator** /*bin_iterator*/) const override {
return nullptr;
}

private:
data_size_t num_data_;
Expand Down