[R-package] remove unused internal variables #5991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
commented
Jul 19, 2023
| @@ -1341,7 +1341,7 @@ test_that("Booster's print, show, and summary work correctly", { | |||
| .has_expected_content_for_fitted_model(log_txt) | |||
|
|
|||
| # summary() | |||
| log_text <- capture.output({ | |||
| log_txt <- capture.output({ | |||
There was a problem hiding this comment.
This one was actually a bug! The assertions below this check a variable named log_txt, which is the output of the previous command. With this change, that assertion actually checks the result of this call.
jmoralez
approved these changes
Jul 21, 2023
guolinke
approved these changes
Jul 21, 2023
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes some unused internal variables in the R package code.
The project's
{lintr}checks andR CMD checkdon't catch these, but PyCharm did 馃榿