Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] use newer h5py in AppVeyor jobs (fixes #5995) #5996

Merged
merged 2 commits into from Jul 20, 2023
Merged

Conversation

jameslamb
Copy link
Collaborator

@jameslamb jameslamb commented Jul 20, 2023

Fixes #5995.

Attempts to force conda to use a newer version of h5py in tests, to avoid the errors in the linked issue related to the combination of newer numpy and older h5py being incompatible.

Also fixes the following error caused by the new release of {lintr} a few hours ago:

[1] Total linting issues found: 1
[[1]]
/home/runner/work/LightGBM/LightGBM/R-package/tests/testthat/test_dataset.R:449:16: warning: [paste] strrep(x, times) is better than paste0(rep(x, times), collapse = "").
long_name <- paste0(rep("a", 1000L), collapse = "")
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

(failed R linting job)

@jameslamb jameslamb changed the title WIP: [ci] use newer h5py in AppVeyor jobs (fixes #5995) [ci] use newer h5py in AppVeyor jobs (fixes #5995) Jul 20, 2023
@jameslamb jameslamb marked this pull request as ready for review July 20, 2023 17:53
@jameslamb jameslamb merged commit 9a84b61 into master Jul 20, 2023
41 checks passed
@jameslamb jameslamb deleted the ci/windows-tests branch July 20, 2023 20:25
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ci] AppVeyor Python CI jobs failing: "module 'numpy' has no attribute 'typeDict' Command"
2 participants