Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R-package] Fix misdetected objective when passing lgb.Dataset instance to lightgbm() #6005

Merged
merged 2 commits into from Sep 4, 2023

Conversation

david-cortes
Copy link
Contributor

This PR fixes an error in which lightgbm() will not set the objective from the default "auto" when the input data is already in the form of a Dataset object.

Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, thanks for the fix! Sorry it took so long to provide a review.

I'll take care of updating this branch and then merging the PR.

@jameslamb jameslamb merged commit bca716c into microsoft:master Sep 4, 2023
41 checks passed
Copy link

github-actions bot commented Dec 6, 2023

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants