Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] fix broken links #6059

Merged
merged 1 commit into from Aug 23, 2023
Merged

[docs] fix broken links #6059

merged 1 commit into from Aug 23, 2023

Conversation

jameslamb
Copy link
Collaborator

@jameslamb jameslamb commented Aug 23, 2023

Fixes broken links in the project's documentation, detected by the link-checks CI job: https://github.com/microsoft/LightGBM/actions/runs/5948642832/job/16132829498.

URL        `https://www.rpmfind.net/linux/fedora/linux/releases/36/Everything/x86_64/os/Packages/m/mingw64-boost-static-1.75.0-6.fc36.noarch.rpm'
Name       `Prebuilt Boost x86_64'
Parent URL file:///home/runner/work/LightGBM/LightGBM/docs/_build/html/GPU-Windows.html, line 180, col 14
Real URL   https://www.rpmfind.net/linux/fedora/linux/releases/36/Everything/x86_64/os/Packages/m/mingw64-boost-static-1.75.0-6.fc36.noarch.rpm
Result     Error: 404 Not Found

URL        `https://www.rpmfind.net/linux/fedora/linux/releases/36/Everything/x86_64/os/Packages/m/mingw32-boost-static-1.75.0-6.fc36.noarch.rpm'
Name       `Prebuilt Boost i686'
Parent URL file:///home/runner/work/LightGBM/LightGBM/docs/_build/html/GPU-Windows.html, line 180, col 213
Real URL   https://www.rpmfind.net/linux/fedora/linux/releases/36/Everything/x86_64/os/Packages/m/mingw32-boost-static-1.75.0-6.fc36.noarch.rpm
Result     Error: 404 Not Found

URL        `https://github.com/microsoft/SynapseML/blob/master/notebooks/features/lightgbm/LightGBM%20-%20Overview.ipynb'
Name       `this SynapseML example'
Parent URL file:///home/runner/work/LightGBM/LightGBM/docs/_build/html/Parallel-Learning-Guide.html, line 176, col 8
Real URL   https://github.com/microsoft/SynapseML/blob/master/notebooks/features/lightgbm/LightGBM%20-%20Overview.ipynb
Result     Error: 404 Not Found

Looks like our friends at SynapseML did their annual "completely re-arrange all the docs" PR 😂

microsoft/SynapseML#2021

And some older releases of Fedora Boost packages were removed from rpmfind.net.

How I tested this

✅ manually triggered the check-links job targeting this branch: https://github.com/microsoft/LightGBM/actions/runs/5952346174

@jameslamb jameslamb added the doc label Aug 23, 2023
@jameslamb jameslamb marked this pull request as ready for review August 23, 2023 14:19
@jameslamb jameslamb merged commit 858eeb5 into master Aug 23, 2023
42 checks passed
@jameslamb jameslamb deleted the docs/broken-links branch August 23, 2023 16:21
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants