Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[c++][fix] Support Quantized Training with Categorical Features on CPU #6301

Merged
merged 13 commits into from
Feb 23, 2024
Merged

[c++][fix] Support Quantized Training with Categorical Features on CPU #6301

merged 13 commits into from
Feb 23, 2024

Conversation

shiyu1994
Copy link
Collaborator

This is to partially fix #6257. Currently quantized training is not supported with categorical features. This PR add the support on CPUs.

@shiyu1994 shiyu1994 mentioned this pull request Feb 5, 2024
Closed
@jameslamb jameslamb removed the fix label Feb 5, 2024
@jameslamb
Copy link
Collaborator

I believe a PR can only have one of the labels recognized by this project's release-drafter configuration at https://github.com/microsoft/LightGBM/blob/master/.github/release-drafter.yml. I removed fix because I think this is more of a feature (even if we initially found out about it because of a bug report).

@shiyu1994
Copy link
Collaborator Author

@jameslamb Thanks for the correction.

@jameslamb jameslamb mentioned this pull request Feb 8, 2024
Closed
@Innixma Innixma mentioned this pull request Feb 13, 2024
Merged
@shiyu1994
Copy link
Collaborator Author

@guolinke Could you help to review this when you have time? Thanks.

guolinke
guolinke reviewed Feb 22, 2024
View reviewed changes
src/treelearner/feature_histogram.cpp
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is from hpp file?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is separated to avoid too large obj file, which causes the failure of this job.
https://dev.azure.com/lightgbm-ci/lightgbm-ci/_build/results?buildId=15803&view=logs&j=1f4df553-f999-5fff-c6fe-71123c872ae2

@shiyu1994 shiyu1994 merged commit 776c5c3 into master Feb 23, 2024
43 checks passed
@shiyu1994 shiyu1994 deleted the fix-6257 branch February 23, 2024 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guolinke guolinke guolinke approved these changes

@jameslamb jameslamb Awaiting requested review from jameslamb jameslamb is a code owner

@jmoralez jmoralez Awaiting requested review from jmoralez jmoralez is a code owner

@borchero borchero Awaiting requested review from borchero borchero is a code owner

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[python-package] [bug] Segfault when combining use_quantized_grad with categorical features
3 participants
@shiyu1994 @jameslamb @guolinke