Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] fix no-response permissions #6323

Merged
merged 2 commits into from
Feb 19, 2024
Merged

[ci] fix no-response permissions #6323

merged 2 commits into from
Feb 19, 2024

Conversation

jameslamb
Copy link
Collaborator

@jameslamb jameslamb commented Feb 16, 2024

Contributes to #6313

How to test this

I think we'll have to merge this PR to test, since workflow_dispatch (the thing that lets you click a button and run it from an arbitrary branch) isn't set up for this workflow.

In this PR, I'm also proposing adding a workflow_dispatch trigger, so we can do that type of testing in the future if needed.

Notes for Reviewers

Looks like the lock-bot config already uses this:

permissions:
issues: write
pull-requests: write

And it shouldn't affect triggering-comments stuff like the valgrind checks, as those use a different secret:

env:
SECRETS_WORKFLOW: ${{ secrets.WORKFLOW }}

@jameslamb jameslamb marked this pull request as ready for review February 16, 2024 07:04
@jameslamb jameslamb changed the title WIP: [ci] fix no-response permissions (fixes #6313) [ci] fix no-response permissions Feb 16, 2024
@jameslamb
Copy link
Collaborator Author

@shiyu1994 can you please restart the VM running for the CUDA jobs? Seems those jobs are getting stuck waiting for a runner to pick them up.

@jameslamb
Copy link
Collaborator Author

thanks for the help @shiyu1994

@jameslamb jameslamb merged commit 685728c into master Feb 19, 2024
43 checks passed
@jameslamb jameslamb deleted the ci/fix-response-bot branch February 19, 2024 20:11
jameslamb added a commit that referenced this pull request Feb 19, 2024
I just learned that GitHub Action `lee-dohm/no-response` doesn't support `workflow_dispatch` events: #6313 (comment)

This reverts that addition from #6323.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants