[R-package] Use Rf_-prefixed versions of protect/unprotect
#6502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-cortes
requested review from
guolinke,
jameslamb,
shiyu1994,
jmoralez and
borchero
as code owners
jameslamb
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From similar PR in XGBoost: dmlc/xgboost#10465
This PR modifies the R C-level function code to call the versions of protect/unprotect that have
Rf_prefixes. This is currently not required by CRAN as their non-Rf equivalentsPROTECT/UNPROTECTare simple defines aliasing toRf_protect/Rf_unprotect, but the situation might change in the future.