Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Spatial Mouse Controller to MRTK3 #10690

Closed

Conversation

sgreenlay-msft
Copy link

@sgreenlay-msft sgreenlay-msft commented Jun 29, 2022

Overview

Adds a new controller that can be added to an MRTK XR Rig to enable a spatial mouse on XR devices (HL2, Quest, PC VR) with similar behaviour to the HL2 system mouse.

GIF 6-27-2022 10-04-40 AM

@Zee2 Zee2 mentioned this pull request Jun 29, 2022
@Zee2 Zee2 self-assigned this Jun 29, 2022
@Zee2 Zee2 added this to the MRTK3 milestone Jun 29, 2022
@Zee2 Zee2 linked an issue Jun 29, 2022 that may be closed by this pull request
@Zee2 Zee2 self-requested a review June 29, 2022 21:08
@Zee2
Copy link
Contributor

Zee2 commented Jun 29, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@@ -0,0 +1,94 @@
{
"name": "MRTK Spatial Mouse Input Actions",
"maps": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this map be included in our default input actions asset? We have several maps in it already (I think HMD, left hand, right hand, and eye gaze), so this could logically fit. Or is there a benefit to it being split out?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was intentionally making this separate because Spatial Mouse is an optional controller and I didn't want to add + activate Input Actions that weren't being used. @Zee2 What do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with either, both justifications are totally reasonable. I think including it in the default action asset isn't a big cost, though, because the user will never really need to worry about it or do anything about it if they don't care about mouse input...

@keveleigh
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sgreenlay-msft
Copy link
Author

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 10690 in repo microsoft/MixedRealityToolkit-Unity

@Zee2
Copy link
Contributor

Zee2 commented Jul 1, 2022

@sgreenlay-msft , some of the scroll-Z math seems to be borked when the camera isn't centered.
wonky_scroll

Repro; just move the camera/head/person/etc and scroll.

@Zee2
Copy link
Contributor

Zee2 commented Jul 1, 2022

Also, now that the cursor stays at the last known depth (and also doesn't resize with distance) if you push an object very far away, the cursor becomes basically invisible until it happens to hit an object again.

@Zee2
Copy link
Contributor

Zee2 commented Jul 1, 2022

Another thing; you should probably remove the proxlight from the mouse because it interferes with the proxlights on the fingertips and hand rays (we only get two, for perf reasons)

@keveleigh
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@AMollis AMollis added MRTK3 GA Feature Request Feature request from the community and removed MRTK3 GA labels Feb 22, 2023
@AMollis AMollis added the Release Blocker Things we must address before the next release. label Mar 2, 2023
@AMollis AMollis assigned shaynie and unassigned Zee2 Mar 2, 2023
@AMollis AMollis modified the milestone: MRTK v3.0 GA Mar 10, 2023
@AMollis AMollis removed the Release Blocker Things we must address before the next release. label Apr 21, 2023
@AMollis
Copy link
Member

AMollis commented Jun 27, 2023

This was completed with the following

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Feature request from the community Input - Mouse MRTK3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spatial Mouse Support
5 participants