Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FancyZones] Feature Request: add hotkey to increment/decrement number of zones in template layouts. #1776

Open
JordanAnthonyKing opened this issue Mar 29, 2020 · 1 comment
Labels
Help Wanted We encourage anyone to jump in on these and submit a PR. Idea-Enhancement New feature or request on an existing product Product-FancyZones Refers to the FancyZones PowerToy
Milestone

Comments

@JordanAnthonyKing
Copy link
Contributor

JordanAnthonyKing commented Mar 29, 2020

Summary of the new feature/enhancement

When using one of the template layouts the user needs to open the settings window each time they want to increase or decrease the number of zones. It would be more convenient if fancy zones provided a keybinding to do this without opening the settings window.

Proposed technical implementation details

Add logic in FancyZones.cpp to respond to a keypress and increment/decrement the zone-count for the active layout.

I have created a local branch that implements this feature using win+ctrl+oem_plus/oem_minus. Further work would be needed to have this setting be optional or to make this binding customisable.

@JordanAnthonyKing JordanAnthonyKing changed the title FancyZones hotkey to increment/decrement number of zones in template layouts. FancyZones add hotkey to increment/decrement number of zones in template layouts. Mar 29, 2020
@JordanAnthonyKing JordanAnthonyKing changed the title FancyZones add hotkey to increment/decrement number of zones in template layouts. FancyZones. Feature Request: add hotkey to increment/decrement number of zones in template layouts. Apr 1, 2020
@JordanAnthonyKing JordanAnthonyKing changed the title FancyZones. Feature Request: add hotkey to increment/decrement number of zones in template layouts. [FancyZones] Feature Request: add hotkey to increment/decrement number of zones in template layouts. Apr 3, 2020
@enricogior enricogior added Idea-Enhancement New feature or request on an existing product Product-FancyZones Refers to the FancyZones PowerToy labels Jun 3, 2020
@enricogior enricogior added the Help Wanted We encourage anyone to jump in on these and submit a PR. label Jul 30, 2020
@enricogior
Copy link
Contributor

Hi @JordanAnthonyKing
this idea seems to fit a limited number of cases, basically only the predefined templates.
Your suggestion is a subset of #2694 that would provide a more general approach and cover not only a few cases.
I marked this "Help Wanted" since we are accepting contribution but we don't plan to add this ourselves.
If you want to open a PR, make sure the implementation is robust and handles all corner cases.
Thanks.

@crutkas crutkas added this to the Help Wanted milestone Sep 14, 2020
@enricogior enricogior reopened this Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted We encourage anyone to jump in on these and submit a PR. Idea-Enhancement New feature or request on an existing product Product-FancyZones Refers to the FancyZones PowerToy
Projects
Status: ⚠️Needs Walkthrough
Development

No branches or pull requests

3 participants