Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image Resizer sizes not spoken by screen readers #19559

Closed
1 task
towebo opened this issue Jul 20, 2022 · 2 comments
Closed
1 task

Image Resizer sizes not spoken by screen readers #19559

towebo opened this issue Jul 20, 2022 · 2 comments
Assignees
Labels
Area-Accessibility Issues related to accessibility Issue-Bug Something isn't working Priority-1 Bug that is high priority Product-Image Resizer Things regarding image resizing module Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@towebo
Copy link

towebo commented Jul 20, 2022

Microsoft PowerToys version

0.60.1

Running as admin

  • Yes

Area(s) with issue?

Image Resizer

Steps to reproduce

  1. Right click on an image and choose Resize in the menu.
  2. Start screen reader Narrator by pressing Ctrl + Windows + Enter.
  3. Tab to the size combo.
  4. Press Alt + Down Arrow to open the combobox.
  5. Move up and down in the list with up and down arrows.

✔️ Expected Behavior

I was expecting the screen reader to actually speak the text for each item in the list.

❌ Actual Behavior

The screen reader Reads the class name of the object in the list because the ToString() has to be overridden to make screen readers work properly.

Other Software

Narrator, NVDA

@towebo towebo added Issue-Bug Something isn't working Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Jul 20, 2022
@crutkas crutkas added Product-Image Resizer Things regarding image resizing module and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Jul 20, 2022
@crutkas
Copy link
Member

crutkas commented Jul 20, 2022

@stefansjfw / @niels9001 easy to repro, i think this is an easy fix, no?

@crutkas crutkas added the Priority-1 Bug that is high priority label Jul 20, 2022
@Jay-o-Way Jay-o-Way added the Area-Accessibility Issues related to accessibility label Jul 20, 2022
@towebo
Copy link
Author

towebo commented Jul 20, 2022

It should only be to override ToString() on both ResizeSize and CustomSize. I see that CustomSize inherits from ResizeSize so perhaps it's enough to fix ResizeSize.ToString().
I can't confirm that it works because I'm unable to compile the solution. Need to install things but have to make room first.

@stefansjfw stefansjfw self-assigned this Jul 21, 2022
@stefansjfw stefansjfw added the Status-In progress This issue or work-item is under development label Jul 21, 2022
@stefansjfw stefansjfw added Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed Status-In progress This issue or work-item is under development labels Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Accessibility Issues related to accessibility Issue-Bug Something isn't working Priority-1 Bug that is high priority Product-Image Resizer Things regarding image resizing module Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Development

No branches or pull requests

4 participants