simplifying the xaml and making things tighter

[crutkas]

Cleaned up the XAML and made things a bit tighter for the text dialog. In results also, there was a 1px gap at the top.

Before:

After:

[AnuthaDev]

@crutkas Shouldn't the inner side of the borders be curved too?🤔

[mdtauk]

@crutkas Shouldn't the inner side of the borders be curved too?🤔

Depends on the inner margin. The outer border edges would be 4px, and you reduce the radius for each pixel in from the edge you go, until you get to 0.

[AnuthaDev]

@mdtauk I guess reduce the border width to 2px then, maybe....

[mdtauk]

@mdtauk I guess reduce the border width to 2px then, maybe....

Windows UI specifies 4px corner radius for UI that overlays other things. 2px for controls like buttons and text boxes

[AnuthaDev]

@mdtauk I meant the BorderWidth not the CornerRadius

[AnuthaDev]

And maybe, ... make it the color of accent color??

[mdtauk]

@mdtauk I meant the BorderWidth not the CornerRadius

Ah, Border widths are now 1px with WinUI - but this is part WinUI and part WPF - so there will be some compromises to get it to work together. I assume the borders are unavoidable.

[AnuthaDev]

@crutkas Can you maybe make it like it was before, just instead of grey, give the outer border accentcolor, plus the dark theme fixes??:

@mdtauk What do you think?

[crutkas]

@crutkas Can you maybe make it like it was before, just instead of grey, give the outer border accentcolor, plus the dark theme fixes??:

that should already be fixed from #2235

Some things may be fixable, others may not also.

[AnuthaDev]

@crutkas I had already seen that PR, I guess I just wanted to say to keep the dark theme fixes.... But that's kind of obvious, so 😅...

[AnuthaDev]

@crutkas I don't exactly know this will work, but could you please try this:

Pseudocode:

In MainWindow.xaml:
For the SearchBoxBorder, make the BorderThickness = 1, add Padding=4

In MainWindow.xaml.cs:
Below line 184 add:
this.SearchBoxBorder.Background = new SolidColorBrush(borderColor);

Change the line below this one(185) to:
this.SearchBoxBorder.BorderBrush = System.Windows.Media.Brushes.Red;

If it works correctly, you can then maybe add the code to change the border color to the accent color ....

[mdtauk]

@crutkas I don't exactly know this will work, but could you please try this:

Pseudocode:

In MainWindow.xaml:
For the SearchBoxBorder, make the BorderThickness = 1, add Padding=4

In MainWindow.xaml.cs:
Below line 184 add:
this.SearchBoxBorder.Background = new SolidColorBrush(borderColor);

Change the line below this one(185) to:
this.SearchBoxBorder.BorderBrush = new SolidColorBrush(Color.RED);

If it works correctly, you can then maybe add the code to change the border color to the accent color ....

The Accent colour and a 2px border is usually used for a TextBox that has focus for typing into. 1px and 60% of the foreground colour when enabled but at rest.

[AnuthaDev]

@mdtauk I guess the TextBox here would always be in focus as long as its visible?

[mdtauk]

@mdtauk I guess the TextBox here would always be in focus as long as its visible?

Unless you tab into the auto-complete list items...

[AnuthaDev]

Unless you tab into the auto-complete list items...

@mdtauk #2222 disagrees:

This is needed to be handled manually because we want to keep the focus on the textbox while the user is tabbing or using the arrow keys

[ryanbodrug-microsoft]

LGTM. Just a heads up that the commits for 3a584e3 and c3bded6 don't seem to be in your branch, which is why the buttons look different in the after screenshot.

[ryanbodrug-microsoft]

Unless you tab into the auto-complete list items...

@mdtauk #2222 disagrees:

This is needed to be handled manually because we want to keep the focus on the textbox while the user is tabbing or using the arrow keys

@mdtauk @AnuthaDev Yes this is correct, we are trying to make it easy for users to refine their searches and action on them as quickly as possible, without having to tab or arrow key back to the text box. If your seeing the result list get focus, then that's a bug.