This repository has been archived by the owner on Jan 12, 2024. It is now read-only.
Adding CControlled function to the canon, w/ unit tests. #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
bettinaheim
reviewed
May 7, 2018
| /// ## bit | ||
| /// a boolean that controls whether op is applied or not. | ||
| /// ## target | ||
| /// Qubit to which the operation is applied. |
There was a problem hiding this comment.
I'd suggest to edit that, since the target does not necessarily have to be a qubit.
Same for all documentations below.
| /// | ||
| /// # Type Parameters | ||
| /// ## 'T | ||
| /// The type of the operation to be conditionally applied. |
There was a problem hiding this comment.
Being a bit pedantic here, I'd modify the description to say the input type of the operation, since the type of the operation indeed includes the entire signature.
Same for all documentations below.
| /// | ||
| /// # Type Parameters | ||
| /// ## 'T | ||
| /// The type of the operation to be conditionally applied. |
There was a problem hiding this comment.
Same here: 'T is the input or argument type of the operation.
| controlled adjoint auto | ||
| } | ||
|
|
||
| operation CControlledActual(op : (Qubit => ()), target : Qubit[]) : () { |
There was a problem hiding this comment.
Do you mind adding the same thing for CControlledA, CControlledC, CControlledCA (I think putting them in the same test is fine)? Otherwise I can quickly add them - just for the sake of always having at least one test that covers every piece of code. I apologize for the hassle of having to make the distinction for operations supporting various functors in the first place; we are working on making this more convenient.
guojing0
pushed a commit
to guojing0/Quantum
that referenced
this pull request
Jul 10, 2018
* Adding CControlled function to the cannon, w/ unit tests. * Fixed doc strings and tests as suggested in PR
jwittner
pushed a commit
to jwittner/Quantum
that referenced
this pull request
Dec 16, 2019
* Fixing doc gen call (microsoft#39) * fixing doc gen call * adding a test for docs generation * need to generate docs for source files only such that we can build the docs for muliple dlls without interferences * forgot to check if the dictionary exists before clearning it in test * Updating qdk to latest version
jwittner
pushed a commit
to jwittner/Quantum
that referenced
this pull request
Dec 16, 2019
) * Updating QDK to latest version. (microsoft#53) * Fixing doc gen call (microsoft#39) * fixing doc gen call * adding a test for docs generation * need to generate docs for source files only such that we can build the docs for muliple dlls without interferences * forgot to check if the dictionary exists before clearning it in test * Updating qdk to latest version * Fixing vs code extension build script on linux (microsoft#56) * fixing a stackoverflow for large files (microsoft#55) * Build VS Code dependencies from either pwsh or powershell. (microsoft#59) * Add automatic indentation to Visual Studio extension (microsoft#60) * Add automatic indentation to Visual Studio extension * Find the indentation of the last non-empty line The previous line can be empty, which would reset the indentation to 0 if e.g. you pressed enter twice in a row. Loop backwards to find the last non-empty line and use that line's indentation instead. * Remove assumption from GetLastNonEmptyLine * Move QsSmartIndentProvider to the top of the file * Flip order of ternary operator in GetIndentation * Add doc comment to GetDesiredIndentation * Add note about nullable return type of GetDesiredIndentation * Show signature help for the first argument (microsoft#63) We also trigger signature help on "(" * Always log exceptions from file queries in debug mode (microsoft#70) * Handling specialization redeclarations (microsoft#85) * Add install template and new project commands to VS Code extension. (microsoft#79) * Compile time errors for overflowing int and double literals (microsoft#87)
cgranade
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new function and operation with unit tests.