Fix build errors in VS2019 and Build Tools v142

[byteduck]

Without this, building in VS2019 results in multiple function is not a member of std errors. This fixes that. 😃

EDIT: Important to mention I'm using VS2019 16.0.3 and build tools v. 142.

[philselmer]

Verified this fixes compilation errors using VS2019 16.0.3 with build tools v142.

[wi-ry]

Resolved VS2019 build issue for me

[rw3iss]

Got it to build in VS2019 after following this and also installed the WinRT C++ library, but debugging throws memory exception, oddly.
Please see #461
#461 (comment)

[vhanla]

@rw3iss Where do I get WinRT C++ Library?

I get error on TerminalCore:

error code "winrt/Microsoft.Terminal.Settings.h" not found in Terminal.cpp line 13

[rw3iss]

@vhanla Read my comment?
https://marketplace.visualstudio.com/items?itemName=CppWinRTTeam.cppwinrt101804264

[adjlyadv]

nice work

[mahmoudajawad]

Do I still need to download VS2017 build tools? I'm still getting this error after applying your patch:

The build tools for v142 (Platform Toolset = 'v142') cannot be found. To build using the v142 build tools, please install v142 build tools.  Alternatively, you may upgrade to the current Visual Studio tools by selecting the Project menu or right-click the solution, and then selecting "Retarget solution".

[philselmer]

@AjawadMahmoud - I think you just need to change the build type from ARM64 to x64 or install the v142 build tools for ARM.

[zadjii-msft]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[ankitbko]

I managed to build it is VS2019 without changing target to v142 and without any code change. Followed this to install WinRT and then right-clicked on solution -> install missing feature.

[Gnbrkm41]

Is this supposed to be done? on VS17 it seemed to work fine without the include. @ ankitbko seems to be suggesting it can be done without changes as well.

[zadjii-msft]

You shouldn't install the cppwinrt VSIX anymore, that's been deprecated in favor of the nuget package.

I was wrong about this, the VSIX does have some natvis defs in it, but it doesn't have the build rules anymore.

[mahmoudajawad]

@philselmer, hmm.. I tried many scenarios but was always ended up with some errors.
I'll spare some more time on this later.

[ankitbko]

You shouldn't install the cppwinrt VSIX anymore, that's been deprecated in favor of the nuget package.

Is this really deprecated? It is still present in official docs of WinRT. Nuget Package description mentions that MSBuild support is removed from vsix but I am not sure if there are other dependencies required by the project that is included in this visx.

[zadjii-msft]

Ahhh okay I see what they've done. I'm dealing with outdated information from the last time we met with them. I see now that the VSIX does have some natvis stuff to make debugging easier. When we were last working with them, we were helping get the build rules into nuget, but I didn't realize they kept the vsix. That's my bad.