Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Dark Syntax Highlight when navigating docs #342

Closed
IagoLast opened this issue Mar 14, 2020 · 5 comments
Closed

Suggestion: Dark Syntax Highlight when navigating docs #342

IagoLast opened this issue Mar 14, 2020 · 5 comments
Labels
You Can Do This A ticket which has been greenlighted as will be accepted

Comments

@IagoLast
Copy link

IagoLast commented Mar 14, 2020

Hi there 馃憢

Just found a banner asking for suggestions about the new page so here you got my 2 cents.

I got dark mode enabled and I think it would be nice having the code snippets on a dark scheme too.

Example of a snippet with the VSCODE theme

Regards

@orta
Copy link
Contributor

orta commented Mar 15, 2020

One day, but the syntax highlighter gives raw color hex values, so it'd take some work to make that happen.

@Enteleform
Copy link

This.

Seriously.

Me, upon witnessing the supreme contrast of the redesign:
dont. do. it.


Go with a dark theme, or a light theme. Please don't do both 馃檹 馃憗 鈿★笍 馃檯鈥嶁檪

(unless you have a toggle that allows you to pick one or the other...) 馃憟 馃挴 馃憣

@orta
Copy link
Contributor

orta commented Mar 15, 2020

You're welcome to take a look at it, until then it's in the backlog 馃憤

@tjjfvi
Copy link
Contributor

tjjfvi commented Oct 23, 2020

This is a code snippet I've used to dark mode things in the past. It attempts to keep the "color" of the color relatively unmodified, while swapping light/dark.

import Color from "color";

function darkModeColor(color: Color){
    const inversionAmount = Math.pow(1 - color.saturationv() / 100, 2);
    color = color.mix(color.negate(), inversionAmount);
    return color;
}

It would be great if someone could implement this or similar; the contrast is painful atm.

falinsky added a commit to falinsky/TypeScript-Website that referenced this issue Jan 30, 2021
@orta
Copy link
Contributor

orta commented Mar 10, 2021

This has been fixed 馃憤馃徎

@orta orta closed this as completed Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
You Can Do This A ticket which has been greenlighted as will be accepted
Projects
None yet
Development

No branches or pull requests

4 participants