Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove polyfill.io #3036

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Remove polyfill.io #3036

merged 1 commit into from
Mar 1, 2024

Conversation

SukkaW
Copy link
Contributor

@SukkaW SukkaW commented Mar 1, 2024

TypeScript website loads polyfill from polyfill.io inside the <Layout />. The PR replaces polyfill.io with cdnjs.cloudflare.com/polyfill.


polyfill.io was acquired by a China-based CDN company "Funnull", see the announcement from the polyfill.io domain owner's Twitter and https://github.com/polyfillpolyfill/polyfill-service/issues/2834. Despite Funnull's claims of operating in the United States, the predominance of Simplified Chinese on its website suggests otherwise, and it turns out that "Funnull" is notorious for providing service for the betting and pornography industries.

The original creator of the polyfill.io has voiced his concern on Twitter. And since the acquisition, numerous issues have emerged (polyfillpolyfill/polyfill-service#2835, polyfillpolyfill/polyfill-service#2838, alist-org/alist#6100), rendering the polyfill.io service extremely unstable. Since then, Fastly (Announcement) and Cloudflare (Announcement) has hosted their own instances of polyfill.io service.

@jakebailey
Copy link
Member

Can we just remove the polyfill.io reference entirely? It's 2024; all modern browsers are evergreen.

@SukkaW
Copy link
Contributor Author

SukkaW commented Mar 1, 2024

Can we just remove the polyfill.io reference entirely? It's 2024; all modern browsers are evergreen.

Don't know why polyfill.io was even introduced back then. But since it is 2024 already, let's assume all browsers now have ES6 support. I will rebase my PR.


@jakebailey I've rebased my PR and polyfill.io usage is now removed.

@SukkaW SukkaW changed the title Replace polyfill.io Remove polyfill.io Mar 1, 2024
@jakebailey jakebailey added the deploy-preview Enables automatic deployments to preview environments on a PR label Mar 1, 2024
@jakebailey jakebailey merged commit 2ca478b into microsoft:v2 Mar 1, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy-preview Enables automatic deployments to preview environments on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants