Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Translate] translate head-seo, community and documentation to ja #984

Conversation

bobstrange
Copy link
Contributor

@bobstrange bobstrange commented Aug 29, 2020

Overview

Part of #220

Translate app (head-seo, community and documentation) to ja.

Diff from English ver is:
https://github.com/bobstrange/TypeScript-Website/compare/98180c5...bobstrange:translate/head-community-documentation-to-ja?expand=1

Remarks

There are some // TODO Remove:Unused comments.
I'm going to open another PR for removing them later.

@bobstrange
Copy link
Contributor Author

#987 should fix failing test 🙇

@bobstrange bobstrange force-pushed the translate/head-community-documentation-to-ja branch from d50e68c to 4c6aa87 Compare August 30, 2020 07:44
Copy link
Contributor

@sasurau4 sasurau4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ちょっとコメントしました

packages/typescriptlang-org/src/copy/ja/documentation.ts Outdated Show resolved Hide resolved
doc_frameworks_asp_blurb:
"モダンなクラウドベースのアプリケーションを作るためのフレームワーク",
doc_apis: "Node APIs",
doc_apis_azure_blurb: "VSCodeから素早くビルドとデプロイ",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in minutesの訳がうまい 👍

packages/typescriptlang-org/src/copy/ja/documentation.ts Outdated Show resolved Hide resolved
packages/typescriptlang-org/src/copy/ja/head-seo.ts Outdated Show resolved Hide resolved
Co-authored-by: Daiki Ihara <sasurau4@gmail.com>
@bobstrange
Copy link
Contributor Author

@sasurau4
レビューありがとうございます :-)
suggestionの方反映しました 🙇

@sasurau4
Copy link
Contributor

👍

LGTM

@github-actions github-actions bot merged commit b5761e7 into microsoft:v2 Sep 16, 2020
@github-actions
Copy link
Contributor

Merging because @sasurau4 is a code-owner of all the changes - thanks!

@bobstrange bobstrange deleted the translate/head-community-documentation-to-ja branch September 16, 2020 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants