Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error introduced into 10/28 @next build #11937

Closed
ntilwalli opened this issue Oct 29, 2016 · 5 comments
Closed

Error introduced into 10/28 @next build #11937

ntilwalli opened this issue Oct 29, 2016 · 5 comments
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue High Priority

Comments

@ntilwalli
Copy link

Some change between typescript@2.1.0-dev.20161027 and typescript@2.1.0-dev.20161028 introduced this error into my build. This issue also exists in typescript@2.1.0-dev.20161029

/Users/ntilwalli/dev/spotlight/node_modules/typescript/lib/typescript.js:23590
            result.declarations = symbol.declarations.slice(0);
                                                     ^

TypeError: Cannot read property 'slice' of undefined
    at cloneSymbol (/Users/ntilwalli/dev/spotlight/node_modules/typescript/lib/typescript.js:23590:54)
    at mergeModuleAugmentation (/Users/ntilwalli/dev/spotlight/node_modules/typescript/lib/typescript.js:23683:90)
    at initializeTypeChecker (/Users/ntilwalli/dev/spotlight/node_modules/typescript/lib/typescript.js:41037:25)
    at Object.createTypeChecker (/Users/ntilwalli/dev/spotlight/node_modules/typescript/lib/typescript.js:23527:9)
    at getDiagnosticsProducingTypeChecker (/Users/ntilwalli/dev/spotlight/node_modules/typescript/lib/typescript.js:60181:93)
    at Object.getGlobalDiagnostics (/Users/ntilwalli/dev/spotlight/node_modules/typescript/lib/typescript.js:60490:41)
    at Tsifier.checkSemantics (/Users/ntilwalli/dev/spotlight/node_modules/tsify/lib/Tsifier.js:219:37)
    at Tsifier.compile (/Users/ntilwalli/dev/spotlight/node_modules/tsify/lib/Tsifier.js:179:34)
    at Tsifier.generateCache (/Users/ntilwalli/dev/spotlight/node_modules/tsify/lib/Tsifier.js:156:8)
    at DestroyableTransform.flush [as _flush] (/Users/ntilwalli/dev/spotlight/node_modules/tsify/index.js:73:12)
@aluanhaddad
Copy link
Contributor

Same here it is blowing up in VS Code as soon as it tries to resolve any imports.

@vladima
Copy link
Contributor

vladima commented Oct 29, 2016

@aluanhaddad can you share a repro?

@vladima
Copy link
Contributor

vladima commented Oct 29, 2016

I've reproed it: https://github.com/vladima/repro-11937
@andy-ms it seems to be related to your change with untyped modules, can you please take a look?

@vladima vladima added the Bug A bug in TypeScript label Oct 29, 2016
@vladima vladima assigned ghost Oct 29, 2016
@vladima vladima added this to the TypeScript 2.1.2 milestone Oct 29, 2016
@aluanhaddad
Copy link
Contributor

aluanhaddad commented Oct 29, 2016

@vladima Sorry, I can't reproduce it any longer. I was running with a global install using VS Code typescript.tsdk. I swapped versions to 2.1.0-dev.20161027 afterwards and I no longer observe the issue on reinstallation of 20161028 or 20161029.

Update:
The Repro you just posted does exhibit the issue.

@mhegazy mhegazy added the Fixed A PR has been merged for this issue label Oct 31, 2016
@mhegazy
Copy link
Contributor

mhegazy commented Oct 31, 2016

@ntilwalli and @aluanhaddad the fix should be in tonight's typescript@next. please give it a try and let us know if you are still running into issues.

@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue High Priority
Projects
None yet
Development

No branches or pull requests

4 participants