Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support /// <reference libs="" /> #16627

Closed
alexeagle opened this issue Jun 19, 2017 · 2 comments
Closed

Support /// <reference libs="" /> #16627

alexeagle opened this issue Jun 19, 2017 · 2 comments
Labels
Duplicate An existing issue was already created

Comments

@alexeagle
Copy link
Contributor

At Google, we keep all dependency information in source files, and generate the tsconfig.json file in the build tooling (https://github.com/bazelbuild/rules_typescript/blob/master/internal/common/tsconfig.bzl)

In order to generate the libs[], we currently use some special one-off comment syntax, which is not understood by editors or other tools. It would be much nicer to specify required TS libs in the source file, the same way as for types[].

Currently the behavior is not symmetric:

dep source file tsconfig.json
types /// <reference types="node"/> "types": []
libs ??? "libs": []

We'd like to be able to do /// <reference libs="es2015.collection" />

/cc @evmar

@DanielRosenwasser
Copy link
Member

I believe this a duplicate of #15732. Check out the PR at #15780.

@DanielRosenwasser DanielRosenwasser added the Duplicate An existing issue was already created label Jun 19, 2017
@alexeagle
Copy link
Contributor Author

Awesome thanks Daniel!

@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Duplicate An existing issue was already created
Projects
None yet
Development

No branches or pull requests

2 participants