Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move test files and baselines into subdirectories #42496

Open
Timmmm opened this issue Jan 26, 2021 · 1 comment
Open

Move test files and baselines into subdirectories #42496

Timmmm opened this issue Jan 26, 2021 · 1 comment
Labels
Experience Enhancement Noncontroversial enhancements Suggestion An idea for TypeScript

Comments

@Timmmm
Copy link

Timmmm commented Jan 26, 2021

Bug Report

VSCode can't really handle the number of files in the tests/cases/compiler directory (5386) or tests/baselines/reference (36655). It makes working with those directories very awkward!

There's plenty of scope for subdirectories, e.g.

anyAndUnknownHaveFalsyComponents.ts
anyAsReturnTypeForNewOnCall.ts
anyDeclare.ts
anyIdenticalToItself.ts
anyIndexedAccessArrayNoException.ts
anyInferenceAnonymousFunctions.ts
anyIsAssignableToObject.ts
anyIsAssignableToVoid.ts
anyMappedTypesError.ts
anyPlusAny1.ts
argsInScope.ts
arguments.ts
argumentsAsPropertyName.ts
argumentsAsPropertyName2.ts
argumentsBindsToFunctionScopeArgumentList.ts
argumentsObjectCreatesRestForJs.ts
argumentsObjectIterator01_ES5.ts
argumentsObjectIterator01_ES6.ts
argumentsObjectIterator02_ES5.ts
argumentsObjectIterator02_ES6.ts
argumentsObjectIterator03_ES5.ts
argumentsObjectIterator03_ES6.ts
argumentsReferenceInConstructor1_Js.ts
argumentsReferenceInConstructor2_Js.ts
argumentsReferenceInConstructor3_Js.ts
argumentsReferenceInConstructor4_Js.ts
argumentsReferenceInConstructor5_Js.ts
argumentsReferenceInConstructor6_Js.ts
argumentsReferenceInConstructor7_Js.ts
argumentsReferenceInMethod1_Js.ts
argumentsReferenceInMethod2_Js.ts
argumentsReferenceInMethod3_Js.ts
argumentsReferenceInMethod4_Js.ts
argumentsReferenceInMethod5_Js.ts
argumentsReferenceInMethod6_Js.ts
argumentsReferenceInMethod7_Js.ts
argumentsUsedInObjectLiteralProperty.ts
arithAssignTyping.ts
arithmeticOnInvalidTypes.ts
arithmeticOnInvalidTypes2.ts
arityErrorRelatedSpanBindingPattern.ts
arrayAssignmentTest1.ts
arrayAssignmentTest2.ts
arrayAssignmentTest3.ts
arrayAssignmentTest4.ts
arrayAssignmentTest5.ts
arrayAssignmentTest6.ts

Could be in these subdirectories

any
arguments
arithmetic
arity
arrayAssignment

I think that would cut down the number of subdirectories to something like 1000 which is much more reasonable. It could be a mostly automated change since the tests are named nicely and in most cases you could just group them by their first word (or maybe even first 1/2 letters?).

🔎 Search Terms

large number many files test cases baselines

@RyanCavanaugh RyanCavanaugh added Experience Enhancement Noncontroversial enhancements Suggestion An idea for TypeScript labels Jan 26, 2021
@RyanCavanaugh
Copy link
Member

I wouldn't mind a couple changes here:

  • The baseline output structure should match the test file layout
  • tests/cases/compiler could be organized up in some meaningful way (probably something better than a filename splice)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Experience Enhancement Noncontroversial enhancements Suggestion An idea for TypeScript
Projects
None yet
Development

No branches or pull requests

2 participants