Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support template literal as jsx attribute value #47589

Closed
5 tasks done
Kingwl opened this issue Jan 25, 2022 · 1 comment · May be fixed by #47590
Closed
5 tasks done

Support template literal as jsx attribute value #47589

Kingwl opened this issue Jan 25, 2022 · 1 comment · May be fixed by #47590
Labels
External Relates to another program, environment, or user action which we cannot control.

Comments

@Kingwl
Copy link
Contributor

Kingwl commented Jan 25, 2022 •
edited
Loading

Suggestion

🔍 Search Terms

jsx, template literal

✅ Viability Checklist

My suggestion meets these guidelines:

  • This wouldn't be a breaking change in existing TypeScript/JavaScript code
  • This wouldn't change the runtime behavior of existing JavaScript code
  • This could be implemented without emitting different JS based on the types of the expressions
  • This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
  • This feature would agree with the rest of TypeScript's Design Goals.

⭐ Suggestion

As facebook/jsx#132
@Kingwl Kingwl mentioned this issue Jan 25, 2022
Open
@RyanCavanaugh RyanCavanaugh added the External Relates to another program, environment, or user action which we cannot control. label Jan 25, 2022
@RyanCavanaugh
Copy link
Member

Please open an issue once the linked PR gets merged -- my sense is that is not likely to happen in the near future based on the JSX repo's general level of engagement.

@MartinJohns MartinJohns mentioned this issue Feb 3, 2022
Closed
@tolmasky tolmasky mentioned this issue Feb 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
External Relates to another program, environment, or user action which we cannot control.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add basic supports for template literal as jsx attribute value Kingwl/TypeScript
2 participants
@RyanCavanaugh @Kingwl