Handle seenEmittedFiles which was not being set when emit of a file was complete #33145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as complete. It was issue only when errors are reported before emitting (which puts the files into pendingEmit that needs to check only in seenEmittedFiles) If emit happens before semantic diagnostics query this issue is not repro, because the affected files come into play and those are being set correctly Fixes #31398
… is on (map files are emitted before d.ts)
…y it easily in baseline
This was referenced Aug 29, 2019
|
@typescript-bot pack this |
|
Heya @sheetalkamat, I've started to run the tarball bundle task on this PR at 6587bd7. You can monitor the build here. It should now contribute to this PR's status checks. |
|
Hey @sheetalkamat, I've packed this into an installable tgz. You can install it for testing by referencing it in your and then running |
|
@sheetalkamat I ran this branch on our production codebase test case (from #33061 (comment)) and it seems to fix the issue! Thanks so much for getting this resolved! |
|
@sheetalkamat Will this be in 3.6.x? |
sheetalkamat
requested review from
rbuckton,
sandersn,
andrewbranch,
orta,
RyanCavanaugh and
weswigham
sheetalkamat
force-pushed
the
builderCircularity
branch
from
b2cea62
to
83cac57
Compare
yes |
sandersn
reviewed
Aug 30, 2019
| @@ -214,6 +215,10 @@ namespace ts { | |||
| if (fileExtensionIs(inputFileName, Extension.Dts)) continue; | |||
| const jsFilePath = getOutputJSFileName(inputFileName, configFile, ignoreCase); | |||
| if (jsFilePath) return jsFilePath; | |||
| if (fileExtensionIs(inputFileName, Extension.Json)) continue; | |||
| if (getEmitDeclarations(configFile.options) && hasTSFileExtension(inputFileName)) { | |||
There was a problem hiding this comment.
quick note for @weswigham: this new line will probably need when bringing the js-to-dts PR up to date with master
sandersn
approved these changes
Aug 30, 2019
|
@typescript-bot cherry-pick this to release-3.6 |
|
Hey @sheetalkamat, I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-3.6 manually. |
sheetalkamat
added a commit
that referenced
this pull request
Aug 30, 2019
implement create Hash to be default hashing plus data so we can verify it easily in baseline
sheetalkamat
added a commit
that referenced
this pull request
Aug 31, 2019
timsuchanek
pushed a commit
to timsuchanek/TypeScript
that referenced
this pull request
Sep 11, 2019
…as complete (microsoft#33145) * Add test that fails because file is written multiple times Reported from microsoft#33061 * Handle seenEmittedFiles which was not being set when emit of a file was complete. It was issue only when errors are reported before emitting (which puts the files into pendingEmit that needs to check only in seenEmittedFiles) If emit happens before semantic diagnostics query this issue is not repro, because the affected files come into play and those are being set correctly Fixes microsoft#31398 * make baselining source map optional * Handle emitDeclarationOnly in --build scenario * Ensure we are using d.ts emit as signature even when --declarationMap is on (map files are emitted before d.ts) * Move module specifiers to verifyTsBuildOutput * implement create Hash to be default hashing plus data so we can verify it easily in baseline * Remove failing baseline * Accept correct baseline name
This was referenced Sep 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was issue only when errors are reported before emitting (which puts the files into pendingEmit that needs to check only in
seenEmittedFilesand notseenAffectedFiles)If emit happens before semantic diagnostics query this issue is not repro, because the affected files come into play and those are being set correctly.
Fixes #31398
Thanks to @ericanderson and @bjlaub for getting us the repro.
As part of this I also found out that when
--declarationMapis on in project we were using.d.ts.mapinstead of.d.tsas signature which is not desirable (since the map can change without changing d.ts resulting in complete refresh even if it didn't affect .d.ts). I have fixed this in this PR along with ensuring that we have test case for that. Changed the createHash of SolutionBuilderHost for tests to emitsignature-contentso that its easily diagnosable.