-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the check that if base file name starts with ^ is dynamic file name since those files can exist #36109
Conversation
… name since those files can exist Fixes #35734
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks OK, but do we lose any ability to detect or create dynamic file names since real files can use carat now?
We already have tests for all the scenarios that use dynamic file names and they work, (I think work to retain projectRootPath for open files has rendered this not needed any more) |
@typescript-bot pack this |
Heya @sheetalkamat, I've started to run the tarball bundle task on this PR at 4858f4b. You can monitor the build here. It should now contribute to this PR's status checks. |
@uniqueiniquity @jessetrinity @amcasey can you try our the drop here to see the debugging scenarios are working ok. |
@sheetalkamat sure thing - I actually just built it locally a few moments ago. |
Hey @sheetalkamat, I've packed this into an installable tgz. You can install it for testing by referencing it in your
and then running There is also a playground for this build. |
@sheetalkamat Looks good to me. Tried naming normal files with a leading ^, tried using dynamic files, and tried using dynamic files that start with a leading ^. All seems fine. |
… name since those files can exist (microsoft#36109) Fixes microsoft#35734
Fixes #35734