Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore data- props when excess property checking #36952

Merged
merged 1 commit into from
Feb 25, 2020
Merged

Ignore data- props when excess property checking #36952

merged 1 commit into from
Feb 25, 2020

Conversation

weswigham
Copy link
Member

Fixes #36935

@weswigham
Copy link
Member Author

@sandersn You wanna review this when you get a chance? @orta suggested we should port this to 3.8, since this fixes a regression that's blocking some people from updating.

@weswigham weswigham merged commit e99173a into microsoft:master Feb 25, 2020
weswigham added a commit to weswigham/TypeScript that referenced this pull request Feb 25, 2020
@weswigham
Ignore data- props when excess property checking (microsoft#36952)
1744298
@weswigham weswigham mentioned this pull request Feb 25, 2020
Merged
@weswigham weswigham deleted the ignore-data-props-when-excess-checking branch February 26, 2020 00:00
weswigham added a commit that referenced this pull request Feb 26, 2020
@weswigham
Ignore data- props when excess property checking (#36952) (#37031)
622c206
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandersn sandersn sandersn approved these changes

@RyanCavanaugh RyanCavanaugh Awaiting requested review from RyanCavanaugh

@orta orta Awaiting requested review from orta

Assignees

@weswigham weswigham

Labels
Author: Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TSX data-* props issue with Stricter Assignability Checks to Unions with Index Signatures
3 participants
@weswigham @sandersn @typescript-bot