Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Format param to the tsserver session #41614

Merged
merged 3 commits into from Nov 20, 2020

Conversation

orta
Copy link
Contributor

@orta orta commented Nov 20, 2020

I think this should unblock #41262 - the param format? was introduced to the tsserver API in #38435 . In order to be used by vscode, it needs to be exposed via the session.ts and protocol.ts.

Which is what this PR does, it also adds some extra values to some of the types in the protocol.

@typescript-bot
Copy link
Collaborator

@typescript-bot typescript-bot commented Nov 20, 2020

Thanks for the PR! It looks like you've changed the TSServer protocol in some way. Please ensure that any changes here don't break consumers of the current TSServer API. For some extra review, we'll ping @sheetalkamat, @amcasey, @mjbvz, @minestarks for you. Feel free to loop in other consumers/maintainers if necessary

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug labels Nov 20, 2020
@orta
Copy link
Contributor Author

@orta orta commented Nov 20, 2020

Thanks sheetal!

@orta orta merged commit 9d25e59 into microsoft:release-4.1 Nov 20, 2020
10 checks passed
@sheetalkamat
Copy link
Member

@sheetalkamat sheetalkamat commented Nov 20, 2020

May be we need this for 4.1 patch as well ?

/**
* Optional for backwards compat, use "2020" for modern LSP-like classifications
*/
format?: ts.SemanticClassificationFormat
Copy link
Contributor

@mjbvz mjbvz Nov 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orta Just want to check that this will also update the protocol.d.ts file that we consume. I didn't see the semantic APIs in the d.ts when I last checked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants