Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback on Generated VueJS Code #978

Closed
ali-kha opened this issue Jul 31, 2019 · 2 comments
Closed

Feedback on Generated VueJS Code #978

ali-kha opened this issue Jul 31, 2019 · 2 comments
Labels
In Progress Indicates the issue is currently being worked on

Comments

@ali-kha
Copy link
Collaborator

ali-kha commented Jul 31, 2019

Summary of issues and suggestions from vue experts

  • Use Vue short hands
    • ie. v-bind:foo should be :foo
  • Use @ for paths instead of relative ones
  • Don't use bootstrap!
  • Use foo() instead of foo: function() for component fields
  • Use object syntax for competent props
  • Improve names of reusable components
    • ie. WarningMessage should be BaseWarningMessage
  • On the Vue styling guide, make sure to follow recommended styling as well, not just the essential
@Tanya0609 Tanya0609 added In Progress Indicates the issue is currently being worked on this-week labels Jul 31, 2019
@SahilTara
Copy link
Collaborator

Is removing bootstrap a good idea? Mainly because its used in our other 2 front end frameworks. Just wondering.

@streetcoder123
Copy link
Contributor

@SahilTara We thought about this as well. I think we shall be settling on using bootstrap-vue to be consistent with other frameworks and have something explicit for vue as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
In Progress Indicates the issue is currently being worked on
Projects
None yet
Development

No branches or pull requests

4 participants