Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NavigationView: Flashing underlining #550

Closed
1 of 3 tasks
PapierenTijger opened this issue Sep 5, 2020 · 7 comments
Closed
1 of 3 tasks

NavigationView: Flashing underlining #550

PapierenTijger opened this issue Sep 5, 2020 · 7 comments
Labels
bug Something isn't working

Comments

@PapierenTijger
Copy link

PapierenTijger commented Sep 5, 2020

Is this a totally new sample, an addition to an existing sample page, or a modification of an existing sample page?

  • New sample
  • Addition to existing sample
  • Modification to existing sample

If this is an addition/modification to an existing sample page, which one?
Tying selection and focus - Tabs of the NavigationView sample

Describe the sample

When I click Item 3 and next Item 4, the line under the tab title flashes very shortly under Item 1. This is not very nice looking and it doesn't happen with e.g. NavigationView that switches pane orientation based on window width

Is your sample request related to a problem? Please describe it

It doesn't look smooth when Item1 is underlined shortly when clicking another item. This also happens in my app based on that sample. Not only in the Xaml gallery.

Additional context

I cannot show a screenvideo made with Gamebar because the Xaml gallery doesn't support gamebar.

@Poopooracoocoo
Copy link

You could use OBS or ShareX. I used ShareX for this one and then trimmed it using a website:

ezgif com-gif-maker

@PapierenTijger
Copy link
Author

Thanks - good to know, and I'm glad your screenvideo shows the issue too.

@YuliKl
Copy link

YuliKl commented Sep 8, 2020

That sample also has a problem with the keyboard focus indicator - keyboard focus is missing from the nav items. Probably some custom code that's causing wonkiness.

@PapierenTijger
Copy link
Author

Do you mean custom code in the implementation of the WinUI NavigationView or in the sample? Because I have the same issue in my own code. It is possibly, but not necessarily, the same custom code that introduces this behavior, since I have no idea how they implemented the sample apart from what is shown.
Of course maybe they show it wrong, but it is a sample in a gallery, showing users how to do something. I think, they should show the right way of implementing things, so users can copy that.
By the way, I turned off tying between selection and focus, because it introduced other unwanted behavior.

@marcelwgn
Copy link
Contributor

I think this issue is caused by the SelectionFollowsFocus property on the NavigationView. Disabling that also removes the weird jumps we are currently experiencing.

@PapierenTijger
Copy link
Author

Indeed, that's the main reason why I removed it from my app. But also because it was responsible for other unwanted behavior: https://stackoverflow.com/questions/63801972/uwp-settings-buttons-to-isenabled-false-triggers-a-tab-change-in-the-navigati

@bpulliam bpulliam added the bug Something isn't working label Oct 11, 2022
@niels9001
Copy link
Contributor

With the design refresh of WinUI 2.5 this issue no longer occurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants