Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WinUI 2 Gallery makes all controls's corner radius 8, deviating from fluent design spec #957

Closed
2 of 13 tasks
roxk opened this issue May 19, 2022 · 1 comment · Fixed by #1007
Closed
2 of 13 tasks
Labels
winui2 Tracks issues in the winui2 branch

Comments

@roxk
Copy link

roxk commented May 19, 2022

Describe the bug
WinUI 2 Gallery is overriding ControlCornerRadius in App.xaml, causing all controls to have a corner radius of 8.

Steps to reproduce the bug
Just launch the app and observe button or check boxes.

Expected behavior
ControlCornerRadius stays at 4. If some specific control needs to have a corner radius of 8, customize the resources only for that control.

Actual behavior

Screenshots
image
You can see WinUI 2's button is rounder, whereas WinUI 3 is "normal", having a corner radius of 4, as defined in WinUI 2.6+ styles.

Gallery version (found on Settings page):
WinUI 2 Gallery 1.2.24.0

Windows 10 version:

  • Insider Build (22621.1)
  • November 2019 Update (18363)
  • May 2019 Update (18362)
  • October 2018 Update (17763)
  • April 2018 Update (17134)
  • Fall Creators Update (16299)
  • Creators Update (15063)
  • Anniversary Update (14393)
    (Shouldn't the template be updated to say Windows 11?)

Device form factor:

  • Desktop
  • Mobile
  • Xbox
  • Surface Hub
  • IoT

Additional context
A UWP community member @yoshiask noticed that the change is introduced in 4fea127, and his guess for the bug is, lemme quote:

Most everything else in that commit is related to the tiles on the home page. I'm guessing they wanted to change the corner radius for those tiles, but instead changed it for literally every control

If this is indeed the case, simply moving the ControlCornerRadius override to HeaderTiles.xaml should fix it while keeping the desired behavior.

@dongle-the-gadget
Copy link

dongle-the-gadget commented May 21, 2022

Looks like this is fixed.

LOL

@marcelwgn marcelwgn added the winui2 Tracks issues in the winui2 branch label Jun 6, 2022
@bpulliam bpulliam linked a pull request Jun 21, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
winui2 Tracks issues in the winui2 branch
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants