Improve performance on deeply nested topics #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riedgar-ms
changed the title
|
@Harsha-Nori I think this is ready to merge now. |
|
Ping @slundberg |
slundberg
approved these changes
Aug 31, 2022
| axis=1 | ||
| ) | ||
| return has_subtopics_df.any() | ||
|
|
There was a problem hiding this comment.
If we still have performance issues we could try vector AND operations here. But this seems good for now :)
There was a problem hiding this comment.
If we stick with a topic tree, I'd be more inclined to rewrite the internal datastructure to be a tree, and just use DataFrame for serialisation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address report of poor performance from FC people, who were using deeply nested topics.
There are two main improvements:
DataFrame.iterrows()loops to useDataFrame.apply()Put in basic tests of the functionality as well.