Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The constructor for
CVModel
inTopicMembershipModel
is incorrect and is causing adatest to throw errors when generating topics:Removed the
fit
call because it happens internally in the__init__
.Also fixed the init to set
class_weight
to 1 for the passed in labels, instead of assuming labels are "pass" / "fail" (forTopicMembershipModel
they are "on_topic" / "off_topic") - I think class_weight = 1 is the default behavior, but will keep for consistencyNow matches the other
CVModel
usage here: https://github.com/microsoft/adatest/blob/a77b5968dca69480aaf11af9a326bafab7c345a8/adatest/_topic_model.py#L93