Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue]: Make the port number optional in JupyterConnectionInfo() #2458

Open
vinodvarma24 opened this issue Apr 20, 2024 · 0 comments
Open
Assignees
Labels
0.2 Issues which were filed before re-arch to 0.4 code-execution execute generated code needs-triage

Comments

@vinodvarma24
Copy link

Describe the issue

Currently, JupyterConnectionInfo() expects a port number when we use a remote Docker server with a Jupiter notebook.

In production use cases, we would want to pass https-enabled hostnames, so there is no need to pass a port number or allow 443 port numbers for an HTTPS connection with the hostname.

Currenlty, it failing and giving error: port number is missing

with DockerJupyterServer() as server:
executor = JupyterCodeExecutor(
jupyter_server=JupyterConnectionInfo(host='xxxxxxxxxx.amazonaws.com', use_https=True, ,
token='xxxxxxxx')
)
print(
executor.execute_code_blocks(
code_blocks=[
CodeBlock(language="python", code="print('Hello, World!')"),
]
)
)

Steps to reproduce

Just try to install jupyter in a serverwith HTTPS enabled with ngnix reverse proxy

Screenshots and logs

No response

Additional Information

No response

@ekzhu ekzhu added the code-execution execute generated code label Apr 20, 2024
@rysweet rysweet added 0.2 Issues which were filed before re-arch to 0.4 needs-triage labels Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.2 Issues which were filed before re-arch to 0.4 code-execution execute generated code needs-triage
Projects
None yet
Development

No branches or pull requests

4 participants