Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It is not possible to use custom HTTP client with requests to Azure Devops #52

Closed
ligurio opened this issue Feb 6, 2020 · 10 comments · Fixed by #103
Closed

It is not possible to use custom HTTP client with requests to Azure Devops #52

ligurio opened this issue Feb 6, 2020 · 10 comments · Fixed by #103

Comments

@ligurio
Copy link

ligurio commented Feb 6, 2020

I'm using Azure Golang SDK and want to use custom HTTP client to access to Azure Devops.
As far as I understand it is not possible now. Please provide such ability.

@tedchamb
Copy link
Member

@ligurio , can you provide more detail on what you are trying to do?

@ligurio
Copy link
Author

ligurio commented May 18, 2020

@tedchamb I'm trying to access to hosted Azure Devops instance with custom SSL certificates. I don't know how to explain in terms of security. Probably my company uses their own SSL PKI and internal sites uses certificates from it.

@pec1985
Copy link

pec1985 commented Jun 11, 2020

+1

@tmeckel
Copy link
Contributor

tmeckel commented Jun 30, 2020

I filed a pull request #49 long ago which could easily be expanded to have the ability to set configuration options on the HTTP client.

@artbegolli
Copy link

artbegolli commented Jul 15, 2020

@tmeckel So I've looked at adding options to enable you to use a custom http client as well as retry based on your implementation.

My concern is that to allow a user to set custom settings or options with NewClientWithOptions function all the auto-generated clients (e.g. git, build, core etc.) must also support the ability to pass in options.

The actual call to NewClient is nested through a few different funcs. @tedchamb, could you share some light into how and where these clients are generated from so I can take a crack at allowing users to specify custom options in all clients?

@artbegolli
Copy link

PR #78

@joyciep
Copy link

joyciep commented Jun 25, 2021

Any updates here? We also need custom HTTP clients

@michalg9
Copy link

michalg9 commented Jul 5, 2021

Any updates here? Seems quite some people are requesting this. There was a PR from @artbegolli making it possible to use custom http client (#78) - it seems to be an extension of PR from @tmeckel (#49) (thanks guys! 🙌). However, both of those PRs are closed and seem not to be included in the main release. Any news on it @tedchamb ? 🙏

@c-brooks
Copy link
Contributor

Hello 👋 I've opened a pull request for a simple way to supply a custom HTTP Client in #103. That PR should close this issue.

@tmeckel
Copy link
Contributor

tmeckel commented Jul 29, 2021

@c-brooks good luck ... I closed my PR #49 here because the repo is definitely abandoned and does not get the care it deserves from Microsoft. So many issues have piled up here that it's kinda ridiculous.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants