Add WithOptions mechanism to Azure DevOps client #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@tedchamb FYI |
|
cc/ @goflores I think you're the owner of the repo? |
goflores
approved these changes
Aug 5, 2021
|
@c-brooks how'd you manage to find out that @goflores is the owner? -> #103 (comment) |
|
yes, that includes the python SDK. |
|
@goflores can you please release the new version with this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #52
Adds a new function,
NewClientWithOptions, to create a new customizable AzureDevOps client.To close the issue, I've added the first option,
WithHTTPClient. This way users can supply their own HTTP clients and set the TLS config themselves.The current
NewClientimplementation is functionally the same, although I refactored it to use theNewClientWithOptionsfunction.cc/ @nigurr