Enhancement: Retryable HTTP Client #49
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmeckel
changed the title
|
This would be very well received, especially for this project! https://github.com/microsoft/terraform-provider-azuredevops |
Oh yes, because the Hashicorp client is used in many other Terraform providers and is able to handle common HTTP errors like 429 automatically. The build branch at https://github.com/tiwood/terraform-provider-azuredevops/tree/build which @tiwood and me are using to build and deploy the Terraform provider are includes this improvement already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains changes to support a retryable HTTP client backend to make the Azure DevOps Go API more resilient against issues of the Azure DevOps REST API. Furthermore it's now possible to pass a logger implementation to the (constructor) function
NewClientWithSettingsvia thetype ClientSettings struct. In addition the derived client implementations have access to this logging implementation because it's accessible via theGetLoggermethod.