Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loc, test class organization, various... #1

Merged
merged 1 commit into from
Mar 10, 2016
Merged

Loc, test class organization, various... #1

merged 1 commit into from
Mar 10, 2016

Conversation

ericsciple
Copy link
Contributor

Not ready to merge.

Execution localization

  • Fixed to use this feature added in .net 4.5 to control all threads' default culture. (Thanks Patrick for the pointer)

Test class organization

  • Started moving classes into namespaces (parallel to production namespace hierarchy)
  • Added overload to TestHostContext ctor to take the test class instance instead of the name of the test class. That way, the trace file name can be formatting using the relative class name (e.g. "Worker_StepsRunnerL0" instead of simply "StepsRunnerL0").

Made StringUtil.Format dumber

  • The method should not determine whether the string should be run through string.format. This can cause issues.
  • I made corresponding changes to the tracing extension methods. I added overloads that do not accept "params object[] args". That way, the compiler will choose the correct overload. If the args overload is chosen, the string will be run through string.format.

Additional small changes

  • Switched console reads/writes to ITerminal
  • Moved some strings to use the loc methods
  • Added some tests
  • other small cleanups...

ericsciple
ericsciple reviewed Mar 6, 2016
View reviewed changes
src/Agent.Listener/Configuration/ConsoleWizard.cs
@@ -33,10 +41,10 @@ public class ConsoleWizard : AgentService, IConsoleWizard
Dictionary<String, String> args,
bool unattended)
{
string def = defaultValue ? "Y" : "N";
string def = defaultValue ? _terminal.Loc("Y") : _terminal.Loc("N");
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Y/N should be localized. I was working on a de-DE OS recently and discovered commands were prompting J/N. I kept entering Y, by habit, and it kept getting rejected.

I'm guessing we still need to support "true" for unattended back compat.

@ericsciple ericsciple changed the title Tests and tracing. Loc, test class organization, various... Mar 8, 2016
bryanmacfarlane
bryanmacfarlane reviewed Mar 9, 2016
View reviewed changes
src/Agent.Listener/MessageListener.cs
Trace.Info(_settings);

//
// Load Credentials
//
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can change this to a single // comment
blank line
// phase comment line here

@ericsciple ericsciple force-pushed the users/ersciple/m97testsandtracing branch 4 times, most recently from bd5cac3 to 1611e44 Compare March 10, 2016 03:41
@ericsciple ericsciple force-pushed the users/ersciple/m97testsandtracing branch from 1611e44 to 58f4d62 Compare March 10, 2016 03:46
ericsciple added a commit that referenced this pull request Mar 10, 2016
@ericsciple
Merge pull request #1 from Microsoft/users/ersciple/m97testsandtracing
9748b83 
Loc, test class organization, various...
@ericsciple ericsciple merged commit 9748b83 into master Mar 10, 2016
@ericsciple ericsciple deleted the users/ersciple/m97testsandtracing branch March 10, 2016 03:47
@steji113 steji113 mentioned this pull request Jun 17, 2016
Closed
@ozitraveller ozitraveller mentioned this pull request Dec 1, 2016
Closed
@Finnegan353 Finnegan353 mentioned this pull request Feb 13, 2017
Closed
@dpksinghal dpksinghal mentioned this pull request May 23, 2017
Merged
@samindustry samindustry mentioned this pull request Jul 5, 2017
Closed
@stephenmichaelf stephenmichaelf mentioned this pull request Aug 11, 2017
Closed
@stephenmichaelf stephenmichaelf mentioned this pull request Aug 24, 2017
Merged
@chshrikh chshrikh mentioned this pull request Oct 10, 2017
Merged
@wsmckenz wsmckenz mentioned this pull request Jun 21, 2018
Closed
@mizho mizho mentioned this pull request Aug 24, 2018
Merged
@tjaffri tjaffri mentioned this pull request Oct 17, 2018
Closed
@gigi81 gigi81 mentioned this pull request Jun 9, 2019
Closed
@hajuuk hajuuk mentioned this pull request Aug 4, 2019
Closed
prebansa pushed a commit to prebansa/azure-pipelines-agent that referenced this pull request Aug 6, 2019
@brcrista
Install MinGW (microsoft#1)
28018e7
prebansa pushed a commit to prebansa/azure-pipelines-agent that referenced this pull request Aug 6, 2019
Merge pull request microsoft#1 from Microsoft/master
682a803 
Take master changes
@ghost ghost mentioned this pull request Sep 10, 2019
Closed
@richardgavel richardgavel mentioned this pull request Sep 11, 2019
Closed
@ArthwitRail ArthwitRail mentioned this pull request Apr 19, 2020
Closed
@zottinor zottinor mentioned this pull request Dec 18, 2020
Closed
@anhdle14 anhdle14 mentioned this pull request Jan 28, 2021
Closed
@vladislav-ryzhov vladislav-ryzhov mentioned this pull request Mar 19, 2021
Closed
@denis-tikhomirov denis-tikhomirov mentioned this pull request Nov 12, 2021
Merged
@marcszy91 marcszy91 mentioned this pull request Jan 19, 2022
Closed
mmrazik pushed a commit that referenced this pull request Nov 15, 2022
@amaswauw @jnilau
MSI connection set up for Azure Container Registry for Container Jobs (…
a42b3f7 
…#3944)

* Update System.Security.Cryptography.ProtectedData

* Update Agent.Worker.csproj

* Updated Agent.Worker.csproj such that a new version of System.Security.Cryptography.ProtectedData can be used for Azure.Identity

* Added support for MSI for Container Jobs for ACR v1.0

* Downgraded .NET version from 4.5.2 to 4.5

* Added a chained credential login such that if managed identity does not work, it will revert to visual studio login

* Added debugging case for MSI/AAD token generation

* Added unit tests for MSI authentication with ACRs

* Update NuGet.Config

* Fixed nits and added tracing to pull a container image using MSI authentication

* Added custom HttpClientHandler for L0 test

* Added traces to track what is going on

* Fixed conditional statement for telemetry

* Simplify MSI changes (#1)

* Simplify MSI changes

* Simplify MSI changes

Co-authored-by: jnilau <109766438+jnilau@users.noreply.github.com>
@dev-win911 dev-win911 mentioned this pull request Mar 22, 2024
Closed
4 tasks
KonstantinTyukalov pushed a commit that referenced this pull request Aug 1, 2024
@srkidd
Merge pull request #1 from srkidd/users/srkidd/enable-stream-and-file…
712bb41 
…-output

Users/srkidd/enable stream and file output
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericsciple @bryanmacfarlane