Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to add tracelog for Featureflag exceptions #4809

Merged

Conversation

dogirala
Copy link
Contributor

@dogirala dogirala commented May 23, 2024

Incase of Failure to fetch FF, right now we are eating up any exception and are logging the failures as a debug print without even logging the exception on the console.log.

Changes are made to

  • Start capturing the exception and logging it to the console of the task as a warning rather than debug print
    image
    The same is reflected onthe pipeline run warnings
    image

  • Logging the same failure to tracelog as error trace which can be monitorited via kalypso

@dogirala dogirala requested review from a team as code owners May 23, 2024 03:17
@kirill-ivlev
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link

Commenter does not have sufficient privileges for PR 4809 in repo microsoft/azure-pipelines-agent

@dogirala
Copy link
Contributor Author

/azp run

Copy link

Commenter does not have sufficient privileges for PR 4809 in repo microsoft/azure-pipelines-agent

@mmrazik
Copy link
Contributor

mmrazik commented May 29, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@DmitriiBobreshev
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@DergachevE DergachevE merged commit beac576 into microsoft:master May 31, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants