Skip to content
This repository has been archived by the owner on Feb 15, 2022. It is now read-only.

Generated pipelines should perform lookup based on pipeline id for first build instead of image tag #1369

Open
2 tasks
samiyaakhtar opened this issue Apr 20, 2020 · 0 comments
Labels
enhancement New feature or request
Projects

Comments

@samiyaakhtar
Copy link
Contributor

samiyaakhtar commented Apr 20, 2020

As a: developer

I want: to optimize the generated pipelines for multi-stage instead of single stage pipelines

So that: spk deployment create logic is simplified to perform lookup based on p1 rather than imageTag. Previously, it was done this way to handle both single stage and multi stage pipelines but for generated pipelines, it's more straightforward to rely on p1.

Describe the solution you'd like:

  • Modify spk deployment create to accept p1 (pipeline id for SRC to ACR) as an argument when adding details for ACR to HLD pipeline, and perform lookup based on p1 as well as imageTag (depending on whatever is passed in), since p1 = p2 in multi-stage pipelines
  • Once this change above is available in a release, consume the changes in generated pipelines

Note that this would be backwards compatible since we don't remove lookup logic for imageTag, which will still support single stage pipelines.

Acceptance Criteria:
spk deployment create lookup logic is simplified for multi-stage pipelines

Describe alternatives you've considered:
Keep it as it is

Additional context:

Does this require updates to documentation?: Yes

@samiyaakhtar samiyaakhtar added the enhancement New feature or request label Apr 20, 2020
@samiyaakhtar samiyaakhtar added this to the Service Introspection milestone Apr 20, 2020
@andrebriggs andrebriggs added this to Ungroomed in Backlog Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
Backlog
  
Ungroomed
Development

No branches or pull requests

1 participant