-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[StyleCop] Set single, unified ruleset file for all project in the solution #1473
Conversation
60a17a5
to
02d4884
Compare
@JuanAr Proving the value of CI builds, the build is failing. Errors are:
|
Note: It seems the master branch is building fine. Per you email, I'm double-checking that now and have a build running. The build that was failing was an experimental build that's about pushing to Azure Artifacts. |
02d4884
to
f64fe72
Compare
f64fe72
to
99eb6b5
Compare
Pull Request Test Coverage Report for Build 51684
💛 - Coveralls |
</PropertyGroup> | ||
|
||
<ItemGroup> | ||
<PackageReference Include="StyleCop.Analyzers" Version="1.0.2" PrivateAssets="all" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why this is both here, and in each of the .csproj files. Could you elaborate?
It seems like only 1 location would be needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @cleemullins, we update the PR for removing the double reference. Now, the StyleCop.Analyzers NuGet is only referenced in the Directory.Build.props file.
…tion.AspNet.WebApi.Tests
fe8a4d0
to
89d03a5
Compare
Fixes #1422 and #1459
Replaces #1429
Description
In this pull request, we unified all the rules from the projects into a single ruleset file and we placed it at the solution level, we use the Directory.Build.props to set this ruleset file to all the projects in the solution
Changes made
Add BotBuilder-DotNet.ruleset file.
Remove the duplicated ruleset files from projects.