Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[StyleCop] Set single, unified ruleset file for all project in the solution #1473

Merged
merged 6 commits into from
Mar 19, 2019

Conversation

JuanAr
Copy link
Collaborator

@JuanAr JuanAr commented Mar 14, 2019

Fixes #1422 and #1459

Replaces #1429

Description

In this pull request, we unified all the rules from the projects into a single ruleset file and we placed it at the solution level, we use the Directory.Build.props to set this ruleset file to all the projects in the solution

Changes made

Add BotBuilder-DotNet.ruleset file.
Remove the duplicated ruleset files from projects.

@JuanAr JuanAr requested a review from cleemullins March 14, 2019 20:40
@JuanAr JuanAr force-pushed the fix/set-unified-ruleset-file branch from 60a17a5 to 02d4884 Compare March 15, 2019 15:09
@cleemullins
Copy link
Contributor

@JuanAr Proving the value of CI builds, the build is failing.

Errors are:

##[error]tests\integration\Microsoft.Bot.Builder.Integration.AspNet.WebApi.Tests\Microsoft.Bot.Builder.Integration.AspNet.WebApi.Tests.csproj(168,5): Error : This project references NuGet package(s) that are missing on this computer. Use NuGet Package Restore to download them. For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is ......\packages\xunit.core.2.3.1\build\xunit.core.props.

##[error]tests\Microsoft.Bot.Builder.TestBot.WebApi\Microsoft.Bot.Builder.TestBot.WebApi.csproj(185,5): Error : This project references NuGet package(s) that are missing on this computer. Use NuGet Package Restore to download them. For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is ....\packages\Microsoft.Net.Compilers.2.6.1\build\Microsoft.Net.Compilers.props.

@cleemullins
Copy link
Contributor

Note: It seems the master branch is building fine. Per you email, I'm double-checking that now and have a build running. The build that was failing was an experimental build that's about pushing to Azure Artifacts.

@coveralls
Copy link
Collaborator

coveralls commented Mar 19, 2019

Pull Request Test Coverage Report for Build 51684

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 75.588%

Totals Coverage Status
Change from base Build 51599: 0.0%
Covered Lines: 4304
Relevant Lines: 5694

💛 - Coveralls

</PropertyGroup>

<ItemGroup>
<PackageReference Include="StyleCop.Analyzers" Version="1.0.2" PrivateAssets="all" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why this is both here, and in each of the .csproj files. Could you elaborate?

It seems like only 1 location would be needed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cleemullins, we update the PR for removing the double reference. Now, the StyleCop.Analyzers NuGet is only referenced in the Directory.Build.props file.

@gasper-az gasper-az force-pushed the fix/set-unified-ruleset-file branch from fe8a4d0 to 89d03a5 Compare March 19, 2019 21:51
@cleemullins cleemullins merged commit 344f231 into master Mar 19, 2019
@cleemullins cleemullins deleted the fix/set-unified-ruleset-file branch March 19, 2019 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants