Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port messaging extension - configure settings from C# to JS #1261

Closed
Virtual-Josh opened this issue Oct 4, 2019 · 4 comments · Fixed by #1265
Closed

Port messaging extension - configure settings from C# to JS #1261

Virtual-Josh opened this issue Oct 4, 2019 · 4 comments · Fixed by #1265
Assignees
@EricDahlvang
Labels
4.6 4.6 release

Comments

@Virtual-Josh
Copy link
Contributor

Port message extension - configure settings

https://github.com/microsoft/botbuilder-dotnet/tree/master/tests/Teams/ComposeMessagingExtensions
@Virtual-Josh Virtual-Josh added 4.6 4.6 release teams labels Oct 4, 2019
@Virtual-Josh
Copy link
Contributor Author

This is very similar to the action based extension scenario. I'm not sure who did that one, but it should be fairly straight forward to do. The manifest in this one does have 1 difference:

"canUpdateConfiguration": true,

@EricDahlvang
Copy link
Member

I'll do this one.

@Virtual-Josh
Copy link
Contributor Author

Done.

@Virtual-Josh Virtual-Josh reopened this Oct 7, 2019
@EricDahlvang EricDahlvang mentioned this issue Oct 7, 2019
Merged
@EricDahlvang
Copy link
Member

Closing: pr submitted, awaiting review #1265

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EricDahlvang EricDahlvang

Labels
4.6 4.6 release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Teams] Add composeMessagingExtensionBot microsoft/botbuilder-js
5 participants
@daveta @tsuwandy @EricDahlvang @stevengum @Virtual-Josh