port: Register missingProperties custom function to get all variables the template contains #3885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Danieladu
requested review from
joshgummersall,
stevengum and
a team
as code owners
Pull Request Test Coverage Report for Build 1091225613
💛 - Coveralls |
libraries/botbuilder-dialogs-adaptive/src/functions/missingPropertiesFunction.ts
Show resolved
Hide resolved
libraries/botbuilder-dialogs-adaptive/src/functions/missingPropertiesFunction.ts
Outdated
Show resolved
Hide resolved
libraries/botbuilder-dialogs-adaptive/src/generators/templateEngineLanguageGenerator.ts
Outdated
Show resolved
Hide resolved
libraries/botbuilder-dialogs-adaptive/src/generators/multiLanguageGeneratorBase.ts
Outdated
Show resolved
Hide resolved
libraries/botbuilder-dialogs-adaptive/src/generators/multiLanguageGeneratorBase.ts
Outdated
Show resolved
Hide resolved
libraries/botbuilder-dialogs-adaptive/src/generators/multiLanguageGeneratorBase.ts
Outdated
Show resolved
Hide resolved
libraries/botbuilder-dialogs-adaptive/src/generators/multiLanguageGeneratorBase.ts
Outdated
Show resolved
Hide resolved
libraries/botbuilder-dialogs-adaptive/src/generators/templateEngineLanguageGenerator.ts
Outdated
Show resolved
Hide resolved
libraries/botbuilder-dialogs-adaptive/src/generators/multiLanguageGeneratorBase.ts
Outdated
Show resolved
Hide resolved
joshgummersall
approved these changes
Jul 28, 2021
Danieladu
commented
Aug 3, 2021
| @@ -43,9 +43,11 @@ import { Headers as Headers_2 } from 'node-fetch'; | |||
| import { ImportResolverDelegate } from 'botbuilder-lg'; | |||
| import { IntExpression } from 'adaptive-expressions'; | |||
| import { ListStyle } from 'botbuilder-dialogs'; | |||
| import { MemoryInterface } from 'adaptive-expressions'; | |||
There was a problem hiding this comment.
@joshgummersall Thanks josh for this fix!
joshgummersall
pushed a commit
that referenced
this pull request
Nov 4, 2021
sw-joelmut
added a commit
to southworks/botbuilder-js
that referenced
this pull request
Nov 4, 2021
…et all variables the template contains (microsoft#3885)" (microsoft#3970)" This reverts commit 619ac13.
sw-joelmut
added a commit
to southworks/botbuilder-js
that referenced
this pull request
Nov 4, 2021
…et all variables the template contains (microsoft#3885)" (microsoft#3970)" This reverts commit 619ac13.
joshgummersall
pushed a commit
that referenced
this pull request
Nov 5, 2021
…ePolicy (#3972) (#3973) * Revert "Revert "port: Register missingProperties custom function to get all variables the template contains (#3885)" (#3970)" This reverts commit 619ac13. * fix: useLanguagePolicy setting turn state, instead of languagePolicy Co-authored-by: Joel Mut <62260472+sw-joelmut@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3849
Description
Register a new custom function:
missingProperties, which could get all the variables the template contains.