Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Revert: "port: Register missingProperties custom function to get all variables the template contains" #3970

Merged
merged 1 commit into from
Nov 3, 2021
Merged

fix: Revert: "port: Register missingProperties custom function to get all variables the template contains" #3970

merged 1 commit into from
Nov 3, 2021

Conversation

joshgummersall
Copy link
Contributor

Reverts #3885

Fixes #3969

Revert "port: Register missingProperties custom function to get all v…
85f2afc 
…ariables the template contains (#3885)"

This reverts commit 3e2beae.
@joshgummersall joshgummersall requested review from stevengum and a team as code owners November 3, 2021 21:28
@coveralls
Copy link

coveralls commented Nov 3, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1418781502

  • 20 of 23 (86.96%) changed or added relevant lines in 3 files are covered.
  • 8 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.05%) to 84.54%
Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder-dialogs-adaptive/src/generators/multiLanguageGeneratorBase.ts 17 20 85.0%
Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-lg/src/templateExtensions.ts 1 84.48%
libraries/botbuilder-dialogs/src/memory/scopes/dialogClassMemoryScope.ts 7 20.83%
Totals Coverage Status
Change from base Build 1386458203: -0.05%
Covered Lines: 19650
Relevant Lines: 22018
💛 - Coveralls

@joshgummersall joshgummersall changed the title revert: "port: Register missingProperties custom function to get all variables the template contains" fix: Revert: "port: Register missingProperties custom function to get all variables the template contains" Nov 3, 2021
@joshgummersall joshgummersall merged commit 619ac13 into main Nov 3, 2021
@joshgummersall joshgummersall deleted the revert-3885-hond/missingproperty branch November 3, 2021 23:22
joshgummersall pushed a commit that referenced this pull request Nov 3, 2021
Revert "port: Register missingProperties custom function to get all v…
e76cca6 
…ariables the template contains (#3885)" (#3970)

This reverts commit 3e2beae.
@joshgummersall joshgummersall mentioned this pull request Nov 3, 2021
Merged
joshgummersall pushed a commit that referenced this pull request Nov 4, 2021
Revert "port: Register missingProperties custom function to get all v…
a8823db 
…ariables the template contains (#3885)" (#3970) (#3971)

This reverts commit 3e2beae.
sw-joelmut added a commit to southworks/botbuilder-js that referenced this pull request Nov 4, 2021
@sw-joelmut
Revert "Revert "port: Register missingProperties custom function to g…
f5e6143 
…et all variables the template contains (microsoft#3885)" (microsoft#3970)"

This reverts commit 619ac13.
sw-joelmut added a commit to southworks/botbuilder-js that referenced this pull request Nov 4, 2021
@sw-joelmut
Revert "Revert "port: Register missingProperties custom function to g…
6a8db19 
…et all variables the template contains (microsoft#3885)" (microsoft#3970)"

This reverts commit 619ac13.
@sw-joelmut sw-joelmut mentioned this pull request Nov 4, 2021
Merged
joshgummersall pushed a commit that referenced this pull request Nov 5, 2021
@sw-joelmut
fix: [#3969] useLanguagePolicy setting turn state, instead of languag…
98dd347 
…ePolicy (#3972)

* Revert "Revert "port: Register missingProperties custom function to get all variables the template contains (#3885)" (#3970)"

This reverts commit 619ac13.

* fix: useLanguagePolicy setting turn state, instead of languagePolicy
joshgummersall pushed a commit that referenced this pull request Nov 5, 2021
@sw-joelmut
fix: [#3969] useLanguagePolicy setting turn state, instead of languag…
83c235b 
…ePolicy (#3972)

* Revert "Revert "port: Register missingProperties custom function to get all variables the template contains (#3885)" (#3970)"

This reverts commit 619ac13.

* fix: useLanguagePolicy setting turn state, instead of languagePolicy
@joshgummersall joshgummersall mentioned this pull request Nov 5, 2021
Merged
joshgummersall pushed a commit that referenced this pull request Nov 5, 2021
@sw-joelmut
fix: [#3969] useLanguagePolicy setting turn state, instead of languag…
b61f335 
…ePolicy (#3972) (#3973)

* Revert "Revert "port: Register missingProperties custom function to get all variables the template contains (#3885)" (#3970)"

This reverts commit 619ac13.

* fix: useLanguagePolicy setting turn state, instead of languagePolicy

Co-authored-by: Joel Mut <62260472+sw-joelmut@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengum stevengum stevengum approved these changes

@luhan2017 luhan2017 Awaiting requested review from luhan2017 luhan2017 was automatically assigned from microsoft/bf-adaptive

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MissingProperties custom function has introduced logic that breaks Core Language bot scenarios
3 participants
@joshgummersall @coveralls @stevengum