Updated Calculator diagnostic data collection per the specification #572
Conversation
…ixed issue where button click telemetry is sent per window close
… to include index loaded
…ed out telemetry points. Cleaned up the TraceLogger.cpp and TraceLogger.h files to remove unused fields and methods.
HowardWolosky
changed the title
… size and item clicked rather than the token
|
Can you please tell how are you implementing "ButtonUsageInSession" Event? |
…emove the int cast
… presses in one event.
ButtonUsageInSession event will be fired periodically throughout the app. It will send the whole ButtonLog array as a string once the array reaches a size of 10. It also sends the array when the app suspends. Originally I was just sending all of the data on suspend, however there was a potential issue where the data would not be sent on a crash or if the process was killed. Sending the button usage data in batches, mitigates this issue so that even if there is data lost it will only be the last 10 button/mode combinations. |
…nType to be a string instead of a bool
| Cube = (int)CM::Command::CommandCUB, | ||
| DMS = (int)CM::Command::CommandDMS, | ||
| // Enum values below are used for Tracelogging and do not map to the Calculator engine | ||
| MemoryAdd, |
There was a problem hiding this comment.
We should set these to well-known integers--otherwise someone might accidentally change them in the future.
…ntegers assigned to them. Updated the LogButtonUsage event to only log if ButtonLog is not empty.
ghost
removed
the
| @@ -299,7 +301,7 @@ namespace CalculatorApp | |||
|
|
|||
| void TraceLogger::LogButtonUsage() | |||
| { | |||
| if (!GetTraceLoggingProviderEnabled()) | |||
| if (!GetTraceLoggingProviderEnabled() || buttonLog.size() == 0) | |||
There was a problem hiding this comment.
This check needs to come after you've taken the lock.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Fixes #525: Refresh Calculator Diagnostic Data.
Description of the changes:
How changes were validated: