Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some letter ligatures might wrong #488

Closed
otomad opened this issue Jun 1, 2021 · 6 comments · Fixed by #587
Closed

Some letter ligatures might wrong #488

otomad opened this issue Jun 1, 2021 · 6 comments · Fixed by #587

Comments

@otomad
Copy link

otomad commented Jun 1, 2021

Environment

Cascadia Code version number: 2102.025

Some wrong ligatures

  • Didn't support ligatures |= == but used to support. (Or for some reason I don't know.)
  • =>> =<< ligatures didn't support in italic, but support in normal font-style.
  • www ligatures in itatic seems has 7 letter "v"??? (Likes vvvvvvv .)
@aaronbell
Copy link
Collaborator

aaronbell commented Jun 1, 2021

@otomad
Copy link
Author

otomad commented Jun 2, 2021

Thanks!

And I found another wrong ligatures in light italic, semilight italic, semibold italic (other italics no problem) #_(

image

The unline looks like a parallelogram. But #_ is no problem.

@aaronbell
Copy link
Collaborator

Thanks, that has already been fixed in source (#475).

@otomad
Copy link
Author

otomad commented Jun 2, 2021

I’ve just seen your pull request (#476) , there are many interesting interpolation issues in Italic, lol.

Then I’ll just report something that hasn't been mentioned there.

  • =|| find in light and semilight (not italic).
  • >>>== in all font-style, what’s that?

image
image
image

@otomad
Copy link
Author

otomad commented Jun 2, 2021

And I'm curious to know why don't show ligatures ~= as now? I remember it used to be shown like this.

@aaronbell
Copy link
Collaborator

Both of those ligatures are fixed in source.

As for ~=, blame Lua #394.

@aaronbell aaronbell mentioned this issue Oct 22, 2021
18 tasks
DHowett pushed a commit that referenced this issue Oct 29, 2021
This is a fairly comprehensive (and spooky!) 🐛💀 update resolving many
open issues.

### Arabic bugfixes
- [x] Closes #532 👻 - Additional positional variants added
- [x] Closes #535 🍂 - Corrected hamza form
- [x] Closes #540 🎃 - Dot arrangement corrected
- [x] Closes #541 🧹 - Was due to the use of anchors on those glyphs.
  These have been removed so the glyph can render as spacing.
- [x] Closes #542 🌕 - This was partly due to a [bug in Harfbuzz]. It
  has been resolved both on the font side (through a different
  implementation) and in Harfbuzz. 
- [x] Closes #549 🦸‍♀️ - Design corrected
- [x] Closes #555 💀 - All letter glyphs removed from Arabic
  Presentation form unicode slots to avoid situations where the glyphs
  are not behaving as expected.
- [x] Related to #543 - uni0615 removed as Cascadia Arabic not intended
  to support Quranic

### Other bug fixes
- [x] Closes #488 🔪 - Finally made the www ligature have the proper
  number of `w`s. 
- [x] Closes #436 🧟‍♀️ - Extended length of Powerline 'caps' to
  avoid situations where rounding can prevent overlap. This may cause
  problems if the caps are used next to one another, but that seems an
  unlikely scenario given what I've reviewed of Powerline styles. 
- [x] Closes #521 🤖 - enlarged the size of the grave character to make
  it more recognizable / legible in code. 
- [x] Closes #524 ☠️ - Added some more differentiation in stroke, and
  also created more space using hinting. 
- [x] Closes #525 🧙‍♂️ - tweaked the braces to be more twisty and
  create better differentiation from the parens. 
- [x] Closes #529 🧛‍♀️ - Changed year :P
- [x] Closes #546 👹 - ij no longer masquerading as a mark. 
- [x] Closes #563 🧟‍♂️ - corrected `locl` feature for proper
  Serbian rendering
- [x] Closes #571 🦹‍♀️ - corrected overshoot
- [x] Closes #572 🕷 - ratio symbol added
- [x] Closes #577 🍁 - shifted heights of box drawing lines to better
  align with block glyphs. Will reduce risk of non-joining forms under
  certain conditions. 

[bug in harfbuzz]: harfbuzz/harfbuzz#3069 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants