Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong italic localised Serbian glyph U+0434 #563

Closed
VeskoRadic opened this issue Aug 22, 2021 · 3 comments · Fixed by #587
Closed

Wrong italic localised Serbian glyph U+0434 #563

VeskoRadic opened this issue Aug 22, 2021 · 3 comments · Fixed by #587

Comments

@VeskoRadic
Copy link

Cascadia family version

2106.17

Cascadia family variant(s)

Cascadia Code (the version with ligatures), Cascadia Mono (the version without ligatures)

Font file format(s)

.ttf (static), .otf (static)

Platform

Linux (freetype 2.10.4)

Other Software

No response

What happened?

Localised Serbian glyph U+0434 CYRILLIC SMALL LETTER DE should look like Bulgarian variation.

The image below shows Russian, Bulgarian and Serbian variants.
image
@aaronbell
Copy link
Collaborator

Thanks! Looks like I missed the substitution in the locl feature. Will update it.

@VeskoRadic
Copy link
Author

Then I guess we can close this?

@aaronbell
Copy link
Collaborator

I’ll keep it open until the fix is PR’d. Easier for tracking 🙂

@aaronbell aaronbell mentioned this issue Oct 22, 2021
Merged
18 tasks
DHowett pushed a commit that referenced this issue Oct 29, 2021
@aaronbell
Spooky October Bugfix (#587)
8881170 
This is a fairly comprehensive (and spooky!) 🐛💀 update resolving many
open issues.

### Arabic bugfixes
- [x] Closes #532 👻 - Additional positional variants added
- [x] Closes #535 🍂 - Corrected hamza form
- [x] Closes #540 🎃 - Dot arrangement corrected
- [x] Closes #541 🧹 - Was due to the use of anchors on those glyphs.
  These have been removed so the glyph can render as spacing.
- [x] Closes #542 🌕 - This was partly due to a [bug in Harfbuzz]. It
  has been resolved both on the font side (through a different
  implementation) and in Harfbuzz. 
- [x] Closes #549 🦸‍♀️ - Design corrected
- [x] Closes #555 💀 - All letter glyphs removed from Arabic
  Presentation form unicode slots to avoid situations where the glyphs
  are not behaving as expected.
- [x] Related to #543 - uni0615 removed as Cascadia Arabic not intended
  to support Quranic

### Other bug fixes
- [x] Closes #488 🔪 - Finally made the www ligature have the proper
  number of `w`s. 
- [x] Closes #436 🧟‍♀️ - Extended length of Powerline 'caps' to
  avoid situations where rounding can prevent overlap. This may cause
  problems if the caps are used next to one another, but that seems an
  unlikely scenario given what I've reviewed of Powerline styles. 
- [x] Closes #521 🤖 - enlarged the size of the grave character to make
  it more recognizable / legible in code. 
- [x] Closes #524 ☠️ - Added some more differentiation in stroke, and
  also created more space using hinting. 
- [x] Closes #525 🧙‍♂️ - tweaked the braces to be more twisty and
  create better differentiation from the parens. 
- [x] Closes #529 🧛‍♀️ - Changed year :P
- [x] Closes #546 👹 - ij no longer masquerading as a mark. 
- [x] Closes #563 🧟‍♂️ - corrected `locl` feature for proper
  Serbian rendering
- [x] Closes #571 🦹‍♀️ - corrected overshoot
- [x] Closes #572 🕷 - ratio symbol added
- [x] Closes #577 🍁 - shifted heights of box drawing lines to better
  align with block glyphs. Will reduce risk of non-joining forms under
  certain conditions. 

[bug in harfbuzz]: harfbuzz/harfbuzz#3069 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Spooky October Bugfix aaronbell/cascadia-code
2 participants
@aaronbell @VeskoRadic